Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neutrino: enable user to assert filter header chain. #3118

Conversation

valentinewallace
Copy link
Contributor

In the case that neutrino's filter header chain is inaccurate, the user can pass in a filter header to neutrino that causes it to reset its chain and resync.

@valentinewallace valentinewallace force-pushed the neutrino-assert-filter-header branch from e1a6a0e to 990c201 Compare May 25, 2019 02:07
@valentinewallace valentinewallace requested a review from Roasbeef May 28, 2019 06:32
@Roasbeef Roasbeef requested review from wpaulino and removed request for Roasbeef May 28, 2019 19:30
go.mod Outdated Show resolved Hide resolved
chainregistry.go Outdated Show resolved Hide resolved
chainregistry.go Outdated Show resolved Hide resolved
chainregistry.go Outdated Show resolved Hide resolved
chainregistry.go Outdated Show resolved Hide resolved
config.go Outdated Show resolved Hide resolved
chainregistry.go Outdated Show resolved Hide resolved
@valentinewallace valentinewallace force-pushed the neutrino-assert-filter-header branch from 990c201 to 499ab74 Compare May 29, 2019 03:43
chainregistry.go Outdated Show resolved Hide resolved
@cfromknecht cfromknecht added this to the 0.7 milestone May 29, 2019
chainregistry.go Outdated Show resolved Hide resolved
chainregistry.go Outdated Show resolved Hide resolved
chainregistry.go Outdated Show resolved Hide resolved
@valentinewallace valentinewallace force-pushed the neutrino-assert-filter-header branch 2 times, most recently from cb6a3b1 to e6749b4 Compare June 1, 2019 00:05
Copy link
Contributor

@cfromknecht cfromknecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

Copy link
Contributor

@wpaulino wpaulino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥁

Copy link
Contributor

@wpaulino wpaulino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocked by lightninglabs/neutrino#152. Will need another dependency update once that's in master.

@cfromknecht
Copy link
Contributor

cfromknecht commented Jun 5, 2019

@valentinewallace ready for dep update

@valentinewallace valentinewallace force-pushed the neutrino-assert-filter-header branch from e6749b4 to d87dc67 Compare June 6, 2019 06:23
config.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@valentinewallace valentinewallace force-pushed the neutrino-assert-filter-header branch from d87dc67 to 25b540f Compare June 6, 2019 23:05
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🗿

@Roasbeef Roasbeef merged commit 52b7603 into lightningnetwork:master Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants