Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lnwallet: add commitment transaction sorting with CLTV tie breaker #3142

Merged
merged 2 commits into from
Jun 5, 2019
Merged

lnwallet: add commitment transaction sorting with CLTV tie breaker #3142

merged 2 commits into from
Jun 5, 2019

Conversation

cfromknecht
Copy link
Contributor

@cfromknecht cfromknecht commented May 30, 2019 •
edited
Loading

Updates commitment transaction sorting to be consistent with lightning/bolts#491

Fixes #2234

@cfromknecht cfromknecht added this to the 0.7 milestone May 30, 2019
Roasbeef
Roasbeef requested changes May 31, 2019
View reviewed changes
lnwallet/channel.go Show resolved Hide resolved
wpaulino
wpaulino approved these changes Jun 3, 2019
View reviewed changes
Copy link
Contributor

@wpaulino wpaulino left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌪

Would be nice to also bring over the set of tests within txsort to test the input sort order behavior.

Roasbeef
Roasbeef approved these changes Jun 5, 2019
View reviewed changes
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏔

@Roasbeef Roasbeef merged commit 970d760 into lightningnetwork:master Jun 5, 2019
@cfromknecht cfromknecht deleted the htlc-tie-breaker branch June 5, 2019 10:08
@t-bast t-bast mentioned this pull request Mar 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpaulino wpaulino wpaulino approved these changes

@Roasbeef Roasbeef Roasbeef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7
Development

Successfully merging this pull request may close these issues.

Invalid commit sig
3 participants
@cfromknecht @Roasbeef @wpaulino