multi: make SendToRoute consistent with other payment RPC #3790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commitment, we make the `SendToRoute` RPC call consistent with all the other payment RPCs which will properly adhere to the current max payment sat limit. This is a prep commit for the future wumbo soft cap that will eventually land in lnd.
…ay size In this commit, we start to clamp the max HTLC forwarding policy to the current register max HTLC payment size. By doing this, we ensure that any links that have a advertised max HTLC transit size above the max payment size will reject any incoming or outgoing attempts for such large payments.
|
I can understand limiting the SendToRoute from paying wumbo invoices, but why kill routing? The network has allowed it without issue and no one has complained ever. Eclair also allows the same and I just asked them and they're not lowering their routing htlc max amount. Bitrefill already has users paying us over the old payment limit with some of them being routed wumbo payments. . . Releasing this as the default will just kill this unless most node operators change their defaults. Why not wait until MPP is out then a change like this isn't such a big deal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we make the
SendToRouteRPC call consistent withall the other payment RPCs which will properly adhere to the current max
payment sat limit. This is a prep commit for the future wumbo soft cap
that will eventually land in lnd. Along the we also add some additional consistency
checks to ensure our externally advertised
MaxHTLCrouting policy is consistentwith this value.