github: update checkout action to v2 #4294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
reviewed
May 18, 2020
carlaKC
force-pushed
the
actions-updatecheckout
branch
from
b892698 to
db17750
Compare
guggero
approved these changes
May 18, 2020
|
Hm, old linter error is back: Need to set |
Checkout v1 has a known flake: actions/checkout#23 (comment). For our linter to pass, we need to checkout our full history (default depth is 1 commit). We could set fetch-depth, but we will eventually move that depth past the linter's start point commit and need to implement another fix. Indead, we add an extra step in our linter to fetch full history so that the linter reference commit is found.
carlaKC
force-pushed
the
actions-updatecheckout
branch
from
db17750 to
d29271f
Compare
|
Fetch depth defaults to 1, and does not seem to have an option for "no depth". Instead added an additional step to get all history so that the linter reference point is found, as in example. Another option would be to add fetch-depth=maxint? |
guggero
approved these changes
May 18, 2020
| uses: actions/checkout@v2 | ||
|
|
||
| - name: Fetch all history for linter | ||
| run: git fetch --prune --unshallow |
There was a problem hiding this comment.
Nice idea, I think that's good for now as we only need the full history for the linter anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checkout v1 has a known flake:
actions/checkout#23 (comment).
Example failed build:
https://github.com/lightningnetwork/lnd/pull/4213/checks?check_run_id=683943940