htlcswitch+peer: introduce packetHandler, ChannelUpdateHandler interfaces for cleaner separation #5603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crypt-iQ
added
p2p
yyforyongyu
reviewed
Aug 5, 2021
htlcswitch/interfaces.go
Outdated
| // came from another peer or if the update was created by user | ||
| // initially. | ||
| // | ||
| // NOTE: This function MUST be non-blocking (or block as little as |
There was a problem hiding this comment.
nit: Though it's copied, I think the comments contradict themselves...
There was a problem hiding this comment.
Changed the comment, PTAL
|
Needs an update to the release notes. |
This allows non-test usages of ChannelLinkConfig to omit the raw htlcswitch.Switch pointer.
This will allow separating the now-private *htlcPacket methods from the publicly-used ChannelLink interface methods.
GetLink, GetLinksByInterface now use ChannelUpdateHandler.
This commit allows the peer to be tested without relying on a raw htlcswitch.Switch pointer. This is accomplished by using a messageSwitch interface and adding the CreateAndAddLink method to the htlcswitch.Switch.
Crypt-iQ
force-pushed
the
peer_switch_refactor_08022021
branch
from
7df36c9 to
db4a488
Compare
|
Added release notes PTAL @yyforyongyu @bhandras |
|
Closing then opening to try to kick travis. |
yyforyongyu
approved these changes
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meant to fix some of the issues outlined in #5067. It removes
*htlcswitch.Switchfrompeerunit tests and replaces it withmockMessageSwitch.