Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mod: bump tlv version to v1.0.1 [skip ci] #6284

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

guggero
Copy link
Collaborator

@guggero guggero commented Feb 21, 2022

Apparently we already pushed a tag named tlv/v1.0.0 a while ago (which
points to a commit not in master)...
We need to bump the version of the tag to v1.0.1 since we cannot replace
old tags (without causing a lot of caching problems).

Apparently we already pushed a tag named tlv/v1.0.0 a while ago (which
points to a commit not in master)...
We need to bump the version of the tag to v1.0.1 since we cannot replace
old tags (without causing a lot of caching problems).
@Roasbeef
Copy link
Member

Removing the top-level replace directive can help us catch things like this in the future at the compile level: if we try to use new features w/o updating the top-level version, then compilation will fail.

@guggero
Copy link
Collaborator Author

guggero commented Feb 22, 2022

Removing the top-level replace directive can help us catch things like this in the future at the compile level: if we try to use new features w/o updating the top-level version, then compilation will fail.

I agree! But it will mean there always need to be three steps for bumping a module:

  • Create PR with updates to module (and optionally add a temporary local replace to use the changes in other modules)
  • Merge the PR then push a new tag for the submodule
  • Create a new PR that bump the submodule version (and removes the temporary local replace)

I wonder if there isn't another way...

@guggero guggero merged commit e7505c3 into lightningnetwork:master Feb 22, 2022
@guggero guggero deleted the tlv-1.0.1 branch February 22, 2022 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants