router: inbound fees support for BuildRoute #7060
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit, the tlv extension of a channel update message is parsed. If an inbound fee schedule is encountered, it is reported in the graph rpc calls.
Preparation for negative fees.
Ensure that negative fees are backwards compatible.
Preparation so that we can have the inbound fee available in addition to the outgoing policy.
Add sender-side support for inbound fees in pathfinding and route building.
|
@joostjager I think this can be closed because of #8886 |
|
I think so too. @joostjager feel free to re-open if there's functionality in this PR that wasn't included in #8886. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapting
BuildRoutefor inbound fees is a bit complicated with the three passes that it does (backwards - forward - backward).I've been experimenting with reducing the number of passes (#6920) and going one step further by re-routing buildroute to pathfinding (#6921).
This PR attempts to add inbound fees support without a major overhaul in how
BuildRouteworks.Builds on #6934. Review first commits there.