Skip to content

Conversation

ziggie1984
Copy link
Collaborator

@ziggie1984 ziggie1984 commented Feb 23, 2023

For the commands SendCoins, SendMany, CloseChannel, OpenChannel, BatchOpenChannel and in the response of the EstimateFee command the option sats_per_kweight is added to allow for more granular control of fees when creating transactions.

In the current fee environment one cannot use decimal fee estimates for sats_per_vbyte, therefore using sats_per_kweight one will be able to use decimal sats_per_vbyte feerates indirectly without introducing floating point math.

Currently in the lnd backend the option sats_per_kweight is prioritized in case both options are present at the same time (sats_per_kweight and sats_per_vbyte). Though having both of them set is prevented on lncli level. This might be open for discussion.

Steps to Test

Changes where done on the rpc level and lncli therefore Polar was used to test all the changed commands.

Pull Request Checklist

Testing

  • Your PR passes all CI checks.
  • Tests covering the positive and negative (error paths) are included.
  • Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

📝 Please see our Contribution Guidelines for further guidance.

@ziggie1984 ziggie1984 force-pushed the master branch 2 times, most recently from c52c513 to 2cfc4ae Compare February 23, 2023 11:12
@ziggie1984 ziggie1984 marked this pull request as ready for review February 23, 2023 11:13
@ziggie1984 ziggie1984 closed this Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant