lnrpc: add tagged hash option to signer.SignMessage/VerifyMessage rpcs #8106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellemouton
reviewed
Oct 23, 2023
orbitalturtle
force-pushed
the
sign-tagged-hash-rpc
branch
3 times, most recently
from
b50b879 to
1ee0a8b
Compare
ellemouton
reviewed
Oct 27, 2023
guggero
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Looks good, pending @ellemouton's and my nits.
Since this is security related, I'm going to pull in @Crypt-iQ as well. Just to make sure we don't allow the user to shoot themselves in the foot with this.
Crypt-iQ
reviewed
Oct 27, 2023
orbitalturtle
force-pushed
the
sign-tagged-hash-rpc
branch
2 times, most recently
from
a1d189c to
c28e329
Compare
Crypt-iQ
approved these changes
Oct 30, 2023
orbitalturtle
force-pushed
the
sign-tagged-hash-rpc
branch
from
c28e329 to
7ca96a6
Compare
|
Thanks for the reviews :) Fixed those nits and the release notes problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to the signrpc.SignMessage rpc to sign a tagged hash of a message. Adds the same option to VerifyMessage so the signature can be properly verified. Replaces #8098.