-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
routing: add TlvTrafficShaper to bandwidth hints #8665
routing: add TlvTrafficShaper to bandwidth hints #8665
Conversation
Important Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
41bc8f4
to
16364fc
Compare
cb514a1
to
f35aead
Compare
cf965f0
to
0e6a9dd
Compare
Was unable to determine why GH isn't linking this PR to the issue
Possibly, not attempting to merge on main? |
0b991e2
to
a5d1e43
Compare
16364fc
to
c2cf4e1
Compare
a5d1e43
to
15abb14
Compare
c2cf4e1
to
0b6cf0e
Compare
1a0b2b2
to
8f1c587
Compare
15abb14
to
09b34f1
Compare
8f1c587
to
7d717d1
Compare
@GeorgeTsagk, remember to re-request review from reviewers when ready |
7d717d1
to
a394230
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, LGTM 🎉
Just nits remaining
0192ea2
to
4051b5d
Compare
4051b5d
to
53e9f28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
5d53431
into
lightningnetwork:0-19-staging
Description
Closes #8617
Based on #8660
This PR adds a
TlvTrafficShaper
function as part of the bandwidth hints. This function can be optionally defined to provide an external way of evaluating whether a channel is capable of carrying out a payment or not.