-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chanbackup: archive old channel backups #9232
base: master
Are you sure you want to change the base?
chanbackup: archive old channel backups #9232
Conversation
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
In this commit, we first check if a previous backup file exists, if it does we copy it to archive folder before replacing it with a new backup file.
In this commit, we add the --disable-backup-archive with a default as false. When set to true then previous channel backup file will not be archived but replaced.
bd7fb87
to
71ee590
Compare
Fixes #8906
Change Description
This PR fixes the issue. By default, it archives channels backups rather than deletes them when new backups are to be saved. The archives are saved with timestamped names to make them easy to find.
Steps to Test
When you start/stop a node and a new backup is about to be written, the previous backup (if available) will be copied to a "channelarchives" folder in the same directory as the main backup file.
Pull Request Checklist
Testing
Code Style and Documentation
[skip ci]
in the commit message for small changes.📝 Please see our Contribution Guidelines for further guidance.