DEVOPS-2694-security-lightrun-installer-container-must-not-consume-secrets-as-env-vars #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

yitzhaktal merged 7 commits into main from DEVOPS-2694-security-lightrun-installer-container-must-not-consume-secrets-as-env-vars

Jun 23, 2025

Contributor

yitzhaktal commented May 25, 2025

No description provided.

yitzhaktal force-pushed the DEVOPS-2694-security-lightrun-installer-container-must-not-consume-secrets-as-env-vars branch 23 times, most recently from 222dfc3 to d3b55a9 Compare

June 1, 2025 09:32


          DEVOPS-2694 - Update the lightrun-k8s-operator deployment to mount Se…

d4efd4d

…crets as files via volumes instead of exposing them as environment variables in containers.

yitzhaktal force-pushed the DEVOPS-2694-security-lightrun-installer-container-must-not-consume-secrets-as-env-vars branch from d3b55a9 to d4efd4d Compare

June 1, 2025 09:35

yitzhaktal requested review from imeliran and moshiko-s

June 1, 2025 09:37


          Merge branch 'main' into DEVOPS-2694-security-lightrun-installer-cont…

18ac708

…ainer-must-not-consume-secrets-as-env-vars

imeliran reviewed

View reviewed changes

charts/lightrun-agents/Chart.yaml Outdated Show resolved Hide resolved

imeliran reviewed

View reviewed changes

charts/lightrun-agents/templates/java-agent-cr.yaml Outdated Show resolved Hide resolved

imeliran reviewed

View reviewed changes

internal/controller/patch_funcs.go Outdated Show resolved Hide resolved

imeliran reviewed

View reviewed changes

lightrun-init-agent/Dockerfile Show resolved Hide resolved

imeliran reviewed

View reviewed changes

lightrun-init-agent/Dockerfile Show resolved Hide resolved

imeliran reviewed

View reviewed changes

lightrun-init-agent/Dockerfile Outdated Show resolved Hide resolved

imeliran requested changes

View reviewed changes

Contributor

imeliran left a comment

Please see my comments

yitzhaktal added 3 commits

June 9, 2025 23:38


          Resolving PR comments

6bfc828


          Merge branch 'DEVOPS-2694-security-lightrun-installer-container-must-…

ee88ce5

…not-consume-secrets-as-env-vars' of github.com:lightrun-platform/lightrun-k8s-operator into DEVOPS-2694-security-lightrun-installer-container-must-not-consume-secrets-as-env-vars


          Resolving PR comments

ecdac1b

Contributor Author

yitzhaktal commented Jun 9, 2025

I have tested this again on OpenShift, latest changes are merged. This was tested using this matrix:

yitzhaktal requested a review from imeliran

June 9, 2025 22:06


          Resolving PR comments

0ec4cf9

imeliran previously approved these changes

View reviewed changes

Contributor

imeliran left a comment

LGTM

yitzhaktal commented

View reviewed changes

internal/controller/patch_funcs.go Outdated Show resolved Hide resolved

yitzhaktal commented

View reviewed changes

internal/controller/patch_funcs.go Outdated Show resolved Hide resolved

yitzhaktal dismissed imeliran’s stale review via

fae7f7b

June 18, 2025 13:53

yitzhaktal requested a review from imeliran

June 18, 2025 13:55

imeliran previously approved these changes

View reviewed changes

yitzhaktal dismissed imeliran’s stale review via

66062ab

June 18, 2025 17:54

yitzhaktal force-pushed the DEVOPS-2694-security-lightrun-installer-container-must-not-consume-secrets-as-env-vars branch 3 times, most recently from 3b88081 to ec6bc42 Compare

June 18, 2025 18:05


          Merge remote-tracking branch 'origin/main' into DEVOPS-2694-security-…

0073e7f

…lightrun-installer-container-must-not-consume-secrets-as-env-vars

yitzhaktal force-pushed the DEVOPS-2694-security-lightrun-installer-container-must-not-consume-secrets-as-env-vars branch from ec6bc42 to 0073e7f Compare

June 18, 2025 18:06

yitzhaktal requested a review from imeliran

June 19, 2025 20:42

Contributor Author

yitzhaktal commented Jun 19, 2025

Double checked my changes on different scenarios with @imeliran's changes of ImagePullSecrets, looks good.

imeliran approved these changes

View reviewed changes

yitzhaktal merged commit 839f305 into main

2 checks passed

yitzhaktal deleted the DEVOPS-2694-security-lightrun-installer-container-must-not-consume-secrets-as-env-vars branch

June 23, 2025 09:04

yitzhaktal added a commit that referenced this pull request


          Revert "Merge pull request #46 from lightrun-platform/DEVOPS-2694-sec…

c520f99

…urity-lightrun-installer-container-must-not-consume-secrets-as-env-vars"

This reverts commit 839f305, reversing
changes made to c174820.

yitzhaktal added a commit that referenced this pull request


          Merge pull request #49 from lightrun-platform/DEVOPS-2694-security-li…

7c90c92

…ghtrun-installer-container-must-not-consume-secrets-as-env-vars-REVERT

Revert "Merge pull request #46 from lightrun-platform/DEVOPS-2694-sec…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet