Skip to content

Revert "Merge pull request #46 from lightrun-platform/DEVOPS-2694-sec… #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025
Merged

Revert "Merge pull request #46 from lightrun-platform/DEVOPS-2694-sec… #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/tests_data/lightrunjavaagent.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ spec:
deploymentName: sample-deployment
secretName: lightrun-secrets
serverHostname: dogfood.internal.lightrun.com
useSecretsAsMountedFiles: false
agentEnvVarName: JAVA_TOOL_OPTIONS
agentConfig:
max_log_cpu_cost: "2"
Expand Down
4 changes: 0 additions & 4 deletions api/v1beta/lightrunjavaagent_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,6 @@ type LightrunJavaAgentSpec struct {
// +optional
// Agent name for registration to the server
AgentName string `json:"agentName,omitempty"`

// UseSecretsAsMountedFiles determines whether to use secret values as mounted files (true) or as environment variables (false)
// +kubebuilder:default=false
UseSecretsAsMountedFiles bool `json:"useSecretsAsMountedFiles,omitempty"`
}

// LightrunJavaAgentStatus defines the observed state of LightrunJavaAgent
Expand Down
3 changes: 0 additions & 3 deletions charts/lightrun-agents/templates/java-agent-cr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,6 @@ spec:
secretName: {{ .name }}-secret
{{- end }}
serverHostname: {{ .serverHostname }}
{{- if .useSecretsAsMountedFiles }}
useSecretsAsMountedFiles: {{ .useSecretsAsMountedFiles | default false }}
{{- end }}
agentEnvVarName: {{ .agentEnvVarName | default "JAVA_TOOL_OPTIONS" }}
{{- if .agentConfig }}
agentConfig: {{ toYaml .agentConfig | nindent 4 }}
Expand Down
4 changes: 0 additions & 4 deletions charts/lightrun-agents/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ javaAgents: []
# containerSelector:
# - my-container-1
# serverHostname: 'lightrun.example.com'
# useSecretsAsMountedFiles: false
# initContainer:
# image: "lightruncom/k8s-operator-init-java-agent-linux:latest"
# imagePullPolicy: "IfNotPresent"
Expand All @@ -43,7 +42,6 @@ javaAgents: []
# containerSelector:
# - my-container-2
# serverHostname: 'lightrun.example.com'
# useSecretsAsMountedFiles: false
# agentPoolCredentials:
# existingSecret: "my-existing-secret"
# apiKey: ""
Expand Down Expand Up @@ -71,7 +69,6 @@ javaAgents: []
# containerSelector:
# - my-container-1
# serverHostname: 'lightrun.example.com'
# useSecretsAsMountedFiles: false
# agentEnvVarName: '_JAVA_OPTIONS'
# agentConfig:
# max_log_cpu_cost: "2"
Expand Down Expand Up @@ -103,7 +100,6 @@ javaAgents: []
# containerSelector:
# - my-container-2
# serverHostname: 'lightrun.example.com'
# useSecretsAsMountedFiles: false
# agentEnvVarName: 'JAVA_OPTS'
# agentConfig:
# max_log_cpu_cost: "2"
Expand Down
5 changes: 0 additions & 5 deletions charts/lightrun-operator/crds/lightrunjavaagent_crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,11 +123,6 @@ spec:
Lightrun server hostname that will be used for downloading an agent
Key and company id in the secret has to be taken from this server as well
type: string
useSecretsAsMountedFiles:
default: false
description: UseSecretsAsMountedFiles determines whether to use secret
values as mounted files (true) or as environment variables (false)
type: boolean
workloadName:
description: Name of the Workload that will be patched. workload can
be either Deployment or StatefulSet e.g. my-deployment, my-statefulset
Expand Down
5 changes: 0 additions & 5 deletions config/crd/bases/agents.lightrun.com_lightrunjavaagents.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,11 +124,6 @@ spec:
Lightrun server hostname that will be used for downloading an agent
Key and company id in the secret has to be taken from this server as well
type: string
useSecretsAsMountedFiles:
default: false
description: UseSecretsAsMountedFiles determines whether to use secret
values as mounted files (true) or as environment variables (false)
type: boolean
workloadName:
description: Name of the Workload that will be patched. workload can
be either Deployment or StatefulSet e.g. my-deployment, my-statefulset
Expand Down
1 change: 0 additions & 1 deletion config/samples/agents_v1beta_lightrunjavaagent.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ spec:
workloadType: Deployment
secretName: lightrun-secrets
serverHostname: <lightrun_server> #for saas it will be app.lightrun.com
useSecretsAsMountedFiles: false
agentEnvVarName: JAVA_TOOL_OPTIONS
agentConfig:
max_log_cpu_cost: "2"
Expand Down
5 changes: 0 additions & 5 deletions config/samples/operator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,11 +135,6 @@ spec:
Lightrun server hostname that will be used for downloading an agent
Key and company id in the secret has to be taken from this server as well
type: string
useSecretsAsMountedFiles:
default: false
description: UseSecretsAsMountedFiles determines whether to use secret
values as mounted files (true) or as environment variables (false)
type: boolean
workloadName:
description: Name of the Workload that will be patched. workload can
be either Deployment or StatefulSet e.g. my-deployment, my-statefulset
Expand Down
3 changes: 0 additions & 3 deletions docs/custom_resource.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,6 @@ spec:
# If container not mentioned here it will be not patched
containerSelector:
- app
# useSecretsAsMountedFiles determines whether to use secret values as environment variables (false) or as mounted files (true)
# Default is false for backward compatibility
useSecretsAsMountedFiles: false
---
apiVersion: v1
metadata:
Expand Down
4 changes: 0 additions & 4 deletions examples/lightrunjavaagent.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,3 @@ spec:
- latest
# Agent name. If not provided, pod name will be used
#agentName: "operator-test-agent"

# UseSecretsAsMountedFiles determines whether to use secret values as mounted files (true) or as environment variables (false)
# Default is false for better security practices
useSecretsAsMountedFiles: false
5 changes: 0 additions & 5 deletions examples/operator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,11 +125,6 @@ spec:
Lightrun server hostname that will be used for downloading an agent
Key and company id in the secret has to be taken from this server as well
type: string
useSecretsAsMountedFiles:
default: false
description: UseSecretsAsMountedFiles determines whether to use secret
values as mounted files (true) or as environment variables (false)
type: boolean
workloadName:
description: Name of the Workload that will be patched. workload can
be either Deployment or StatefulSet e.g. my-deployment, my-statefulset
Expand Down
Loading
Loading