Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Release tagging not publishing artifacts to GH release page #449

Closed
sreuland opened this issue Aug 3, 2022 · 4 comments · Fixed by #452 or #453
Closed

CI: Release tagging not publishing artifacts to GH release page #449

sreuland opened this issue Aug 3, 2022 · 4 comments · Fixed by #452 or #453
Assignees
Labels

Comments

@sreuland
Copy link
Contributor

sreuland commented Aug 3, 2022

What version are you using?

latest

What did you do?

Tagged a new release

What did you expect to see?

The new tagged release build jar file added to the Github release

What did you see instead?

no release jar artifact added to the Github release, the CI step to publish the release build jar to GH release is failing on ghr tool

@sreuland sreuland added the bug label Aug 3, 2022
@sreuland sreuland self-assigned this Aug 3, 2022
@sreuland
Copy link
Contributor Author

sreuland commented Aug 3, 2022

cc @tamirms

marcelosalloum added a commit that referenced this issue Aug 8, 2022
### What

Fix the deployment CI that uploads the jar to the GitHub release by updating the image version of cibuilds/github from `0.10` to `0.13`.

### Why

Close #449.

In an attempt to fix the deploy job, that's failing at:
https://github.com/stellar/java-stellar-sdk/blob/b2a93410a39f7b39f4dbb8e462214ae119a3996b/.circleci/config.yml#L20-L29

With the error message:
```text
Failed to upload one of assets: one of the goroutines failed: failed to upload asset: /root/project/build/libs/stellar-sdk.jar: failed to upload release asset: /root/project/build/libs/stellar-sdk.jar: stat /root/project/build/libs/stellar-sdk.jar: use of closed file
```

Example of a failed deploy: [deploy (669)](https://app.circleci.com/pipelines/github/stellar/java-stellar-sdk/539/workflows/de14000a-07fe-481c-8707-787d3f58bd48/jobs/669/steps)

This error seems to have been fixed at tcnksm/ghr#99 and released in version `0.11.0`. Also referenced in tcnksm/ghr#90.
@marcelosalloum
Copy link
Contributor

Oh no, the fix did not work 😔

@marcelosalloum marcelosalloum reopened this Aug 8, 2022
@sreuland
Copy link
Contributor Author

sreuland commented Aug 8, 2022

@marcelosalloum , thanks for working on this one, how are you testing ghr, can you run it on cli locally to a fake GH release and see it work/fail to that?

@marcelosalloum
Copy link
Contributor

I installed ghr using homebrew and it worked fine. Seems like the go version (used in the pipeline) is having problems though.

marcelosalloum added a commit that referenced this issue Aug 11, 2022
…453)

### What

Fix the deployment CI that uploads the jar to the GitHub release by updating the software being used from https://github.com/tcnksm/ghr to https://github.com/github-release/github-release.

### Why

Close #449.

In an attempt to fix the deploy job, that's failing at:
https://github.com/stellar/java-stellar-sdk/blob/417a84bd760321dba1ded0db0b9a32455737424f/.circleci/config.yml#L20-L29

With the error message:
```text
Failed to upload one of assets: one of the goroutines failed: failed to upload asset: /root/project/build/libs/stellar-sdk.jar: failed to upload release asset: /root/project/build/libs/stellar-sdk.jar: Post https://uploads.github.com/repos/stellar/java-stellar-sdk/releases/73913299/assets?name=stellar-sdk.jar: http2: Transport: cannot retry err [stream error: stream ID 5; REFUSED_STREAM] after Request.Body was written; define Request.GetBody to avoid this error
```

Example of a failed deploy: [deploy (678)](https://app.circleci.com/pipelines/github/stellar/java-stellar-sdk/545/workflows/85aac5f6-5744-4716-83cd-5e0ee60032ce/jobs/678)

There was already an attempt to solve this in #452 without success.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment