Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Auth Next. #489

Closed
overcat opened this issue Jul 20, 2023 · 4 comments
Closed

Add support for Auth Next. #489

overcat opened this issue Jul 20, 2023 · 4 comments

Comments

@overcat
Copy link
Member

overcat commented Jul 20, 2023

What problem does your feature solve?

We need to add an interface for users to add signatures in the InvokeHostFunctionOperation.auth.

What would you like to see?

I have added an implementation in the Python SDK, but I'm not sure if it is the optimal solution. I would like to have more discussion on this.

Related discussion: stellar/js-stellar-base#632

What alternatives are there?

None

Estimated working hours: TBD, more discussion is needed.

@overcat overcat changed the title Added support for Auth Next. Add support for Auth Next. Jul 20, 2023
@overcat
Copy link
Member Author

overcat commented Aug 10, 2023

Hi @sreuland, I want to release a beta version after completing #490, so that users can have an early experience and provide feedback.

But due to the lack of sufficient discussion on Auth Next at present, I would like to exclude it from this release and postpone it to a later release. Do you think this is acceptable? We can wait for it to be completed in the JS/Python SDK first.

@sreuland
Copy link
Contributor

yes, sounds like a good approach. Let's pull #489 out of #490.

What will this mean for the type of soroban transactions which can be built and submitted by the first beta java sdk release? Sounds like would mean tx source account is the only address used in contract auths, i.e. SOROBAN_CREDENTIALS_SOURCE_ACCOUNT and that auth entry is built by default with simulation response?

thanks!

@overcat
Copy link
Member Author

overcat commented Aug 11, 2023

yes, sounds like a good approach. Let's pull #489 out of #490.

What will this mean for the type of soroban transactions which can be built and submitted by the first beta java sdk release? Sounds like would mean tx source account is the only address used in contract auths, i.e. SOROBAN_CREDENTIALS_SOURCE_ACCOUNT and that auth entry is built by default with simulation response?

thanks!

Yes, this means that users can only use the SOROBAN_CREDENTIALS_SOURCE_ACCOUNT authentication method, but this is sufficient to meet the majority of current needs. Let's take a break and then come back to improve other content.

@overcat
Copy link
Member Author

overcat commented Sep 19, 2023

Implemented in #537.

@overcat overcat closed this as completed Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants