fix the decoding of balanceId in org.stellar.sdk.ClaimClaimableBalanceOperation.
#310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overcat
force-pushed
the
dev-fix-balanceId
branch
from
63408f8
to
5068b0f
Compare
overcat
commented
Dec 1, 2020
| @@ -22,14 +25,16 @@ public String getBalanceId() { | |||
| org.stellar.sdk.xdr.Operation.OperationBody toOperationBody() { | |||
| ClaimClaimableBalanceOp op = new ClaimClaimableBalanceOp(); | |||
|
|
|||
| ClaimableBalanceID id = new ClaimableBalanceID(); | |||
| id.setDiscriminant(ClaimableBalanceIDType.CLAIMABLE_BALANCE_ID_TYPE_V0); | |||
There was a problem hiding this comment.
The CLAIMABLE_BALANCE_ID_TYPE is already included in the banlanceId.
overcat
force-pushed
the
dev-fix-balanceId
branch
from
5068b0f
to
7faa588
Compare
|
@overcat can you add a test? |
overcat
force-pushed
the
dev-fix-balanceId
branch
from
caf48f8
to
32331b3
Compare
|
Hi @leighmcculloch @tamirms, just added some tests. |
overcat
commented
Dec 2, 2020
| ClaimClaimableBalanceOperation parsedOperation = (ClaimClaimableBalanceOperation) Operation.fromXdr(xdr); | ||
| assertEquals(accountId, parsedOperation.getSourceAccount()); | ||
| assertEquals(balanceId, parsedOperation.getBalanceId()); | ||
| // Generated by js-stellar-base. |
There was a problem hiding this comment.
const stellarBase = require("stellar-base")
const op = stellarBase.Operation.claimClaimableBalance({
balanceId: "000000006d6a0c142516a9cc7885a85c5aba3a1f4af5181cf9e7a809ac7ae5e4a58c825f",
source: "GABTTS6N4CT7AUN4LD7IFIUMRD5PSMCW6QTLIQNEFZDEI6ZQVUCQMCLN"
})
console.log(op.toXDR().toString("base64"))
> AAAAAQAAAAADOcvN4KfwUbxY/oKijIj6+TBW9Ca0QaQuRkR7MK0FBgAAAA8AAAAAbWoMFCUWqcx4hahcWro6H0r1GBz556gJrHrl5KWMgl8=
tamirms
approved these changes
Dec 2, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #309