#374: fix npe on liquidity pool trustline in changetrustresponse #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamirms
approved these changes
Nov 10, 2021
sreuland
force-pushed
the
374_change_trust_reponse_liquidity_asset
branch
from
b5b1d77
to
f0ccceb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, here is draft of changes I think can resolve the npe issue when deser of changetrustresponse, I got hung up on seeing how liquidity pool shares were not defined in XDR Asset, api intentionally throws in XDR Asset ser/deser routines, so I followed that pattern and just addressed enabling the Json deser path in operationresponse for pool share type asset.