Avoid to have unexpected exception on status code 429 TooManyRequests

src/main/java/org/stellar/sdk/requests/ResponseHandler.java

@@ -28,7 +28,11 @@ public T handleResponse(final Response response) throws IOException, TooManyRequ
  try {
  // Too Many Requests
  if (response.code() == 429) {
- int retryAfter = Integer.parseInt(response.header("Retry-After"));
+
+ int retryAfter = -1;
+ if (response.header("Retry-After") != null) {
+ retryAfter = Integer.parseInt(response.header("Retry-After"));
+ }
  throw new TooManyRequestsException(retryAfter);
  }
 

src/main/java/org/stellar/sdk/requests/TooManyRequestsException.java

@@ -13,7 +13,8 @@ public TooManyRequestsException(int retryAfter) {
  }
 
  /**
- * Returns number of seconds a client should wait before sending requests again.
+ * Returns number of seconds a client should wait before sending requests again,
+ * or -1 this time is unknown.
  */
  public int getRetryAfter() {
  return retryAfter;

src/test/java/org/stellar/sdk/requests/ResponseHandlerTest.java

@@ -0,0 +1,65 @@
+package org.stellar.sdk.requests;
+
+import static org.junit.Assert.assertEquals;
+
+import java.io.IOException;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+import okhttp3.OkHttpClient;
+import okhttp3.mockwebserver.MockResponse;
+import okhttp3.mockwebserver.MockWebServer;
+
+public class ResponseHandlerTest {
+
+ @Test
+ public void testTooManyRequests() throws IOException, InterruptedException {
+
+ MockResponse response = new MockResponse();
+ response.setResponseCode(429);
+ response.setHeader("Retry-After", "10");
+
+ MockWebServer mockWebServer = new MockWebServer();
+ mockWebServer.start();
+ mockWebServer.enqueue(response);
+
+ OkHttpClient okHttpClient = new OkHttpClient().newBuilder().build();
+ try {
+
+ AccountsRequestBuilder.execute(okHttpClient, mockWebServer.url("/"));
+ Assert.fail();
+ } catch (TooManyRequestsException tmre) {
+ assertEquals(10, tmre.getRetryAfter());
+ } finally {
+
+ mockWebServer.shutdown();
+ mockWebServer.close();
+ }
+ }
+
+ @Test
+ public void testTooManyRequestsNoHeader() throws IOException, InterruptedException {
+
+ MockResponse response = new MockResponse();
+ response.setResponseCode(429);
+
+ MockWebServer mockWebServer = new MockWebServer();
+
+ mockWebServer.start();
+ mockWebServer.enqueue(response);
+
+ OkHttpClient okHttpClient = new OkHttpClient().newBuilder().build();
+
+ try {
+ AccountsRequestBuilder.execute(okHttpClient, mockWebServer.url("/"));
+ Assert.fail();
+ } catch (TooManyRequestsException tmre) {
+ assertEquals(-1, tmre.getRetryAfter());
+ } finally {
+
+ mockWebServer.shutdown();
+ mockWebServer.close();
+ }
+ }
+}