-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compatibility on Android platforms below Android API 28 #543
Merged
overcat
merged 20 commits into
lightsail-network:master
from
overcat-deprecation:issue/542
Sep 28, 2023
Merged
Changes from 16 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
98c48d4
Remove commons-codec:commons-codec:1.16.0 and add a base32 copy.
overcat d7721d6
update changelog
overcat ca81119
Improve Android testing.
overcat cf5c407
Copy base64
overcat f033c29
Update XDR
overcat 72f2951
Merge remote-tracking branch 'origin/issue/542' into issue/542
overcat 8d40fd0
empty commit, trigger a pipeline
overcat 8bdee59
set min sdk to 24
overcat 367da02
check base64 string
overcat 5cb5dff
Merge remote-tracking branch 'origin/issue/542' into issue/542
overcat 4ed6821
add License
overcat f8a3373
fix
overcat d88f5de
add test
overcat 3ca599d
SPI
overcat d1e86e6
add docs
overcat ad4ed93
add docs
overcat 503a82c
base32 spi
overcat 0a513a6
Merge branch 'master' into issue/542
overcat 6eded56
update XDRGEN_COMMIT
overcat d423f57
Update test-deploy.yml to use the wretry action for retrying unstable…
overcat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 24 additions & 0 deletions
24
android_test/app/src/main/java/org/stellar/javastellarsdkdemoapp/AndroidSdkProvider.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
package org.stellar.javastellarsdkdemoapp | ||
|
||
import org.stellar.sdk.Base64 | ||
import org.stellar.sdk.spi.SdkProvider | ||
|
||
class AndroidSdkProvider : SdkProvider { | ||
override fun createBase64(): Base64 { | ||
return AndroidBase64() | ||
} | ||
|
||
class AndroidBase64 : Base64 { | ||
override fun encodeToString(data: ByteArray?): String { | ||
return android.util.Base64.encodeToString(data, android.util.Base64.NO_WRAP) | ||
} | ||
|
||
override fun encode(data: ByteArray?): ByteArray { | ||
return android.util.Base64.encode(data, android.util.Base64.NO_WRAP) | ||
} | ||
|
||
override fun decode(data: String?): ByteArray { | ||
return android.util.Base64.decode(data, android.util.Base64.NO_WRAP) | ||
} | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
once https://github.com/overcat/java-stellar-sdk-android-spi is published to jitpack, this can go away correct, and change this example to have dep on that instead?
[edit] oh, actually, i see it's already published to jitpack as a snapshot!
https://jitpack.io/#overcat/java-stellar-sdk-android-spi/-SNAPSHOT