Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A series of improvements. #661

Closed
wants to merge 5 commits into from
Closed

A series of improvements. #661

wants to merge 5 commits into from

Conversation

overcat
Copy link
Member

@overcat overcat commented Nov 14, 2024

No description provided.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 79.77528% with 18 lines in your changes missing coverage. Please review.

Project coverage is 80.96%. Comparing base (54442eb) to head (5cf0209).

Files with missing lines Patch % Lines
src/main/java/org/stellar/sdk/StrKey.java 78.12% 13 Missing and 1 partial ⚠️
src/main/java/org/stellar/sdk/KeyPair.java 93.75% 1 Missing ⚠️
.../main/java/org/stellar/sdk/SorobanDataBuilder.java 0.00% 1 Missing ⚠️
src/main/java/org/stellar/sdk/Transaction.java 0.00% 1 Missing ⚠️
.../main/java/org/stellar/sdk/TransactionBuilder.java 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #661      +/-   ##
============================================
+ Coverage     80.90%   80.96%   +0.06%     
- Complexity     1172     1176       +4     
============================================
  Files           203      202       -1     
  Lines          4436     4450      +14     
  Branches        370      374       +4     
============================================
+ Hits           3589     3603      +14     
+ Misses          617      616       -1     
- Partials        230      231       +1     
Files with missing lines Coverage Δ
src/main/java/org/stellar/sdk/Asset.java 79.16% <ø> (ø)
...ava/org/stellar/sdk/AssetTypeCreditAlphaNum12.java 87.50% <ø> (ø)
src/main/java/org/stellar/sdk/SorobanServer.java 83.73% <ø> (ø)
...java/org/stellar/sdk/TransactionPreconditions.java 94.02% <100.00%> (ø)
...tellar/sdk/exception/AccountNotFoundException.java 100.00% <ø> (ø)
src/main/java/org/stellar/sdk/KeyPair.java 83.96% <93.75%> (+0.46%) ⬆️
.../main/java/org/stellar/sdk/SorobanDataBuilder.java 87.23% <0.00%> (ø)
src/main/java/org/stellar/sdk/Transaction.java 94.00% <0.00%> (ø)
.../main/java/org/stellar/sdk/TransactionBuilder.java 87.71% <80.00%> (ø)
src/main/java/org/stellar/sdk/StrKey.java 90.41% <78.12%> (-1.18%) ⬇️

@overcat overcat closed this Nov 14, 2024
@overcat overcat deleted the rc-improve branch November 15, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant