Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Use IllegalStateException instead of `IllegalArgumentExc… #665

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

overcat
Copy link
Member

@overcat overcat commented Nov 14, 2024

…eption` in some scenarios.

@overcat overcat merged commit ec11098 into master Nov 14, 2024
2 checks passed
@overcat overcat deleted the improve-ex branch November 14, 2024 09:27
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.96%. Comparing base (ae48e08) to head (a56b374).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
.../main/java/org/stellar/sdk/SorobanDataBuilder.java 0.00% 1 Missing ⚠️
src/main/java/org/stellar/sdk/Transaction.java 0.00% 1 Missing ⚠️
.../main/java/org/stellar/sdk/TransactionBuilder.java 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #665   +/-   ##
=========================================
  Coverage     80.96%   80.96%           
- Complexity     1171     1176    +5     
=========================================
  Files           202      202           
  Lines          4439     4450   +11     
  Branches        370      374    +4     
=========================================
+ Hits           3594     3603    +9     
- Misses          615      616    +1     
- Partials        230      231    +1     
Files with missing lines Coverage Δ
src/main/java/org/stellar/sdk/Asset.java 79.16% <ø> (ø)
...ava/org/stellar/sdk/AssetTypeCreditAlphaNum12.java 87.50% <ø> (ø)
src/main/java/org/stellar/sdk/KeyPair.java 83.96% <100.00%> (+0.15%) ⬆️
src/main/java/org/stellar/sdk/SorobanServer.java 83.73% <ø> (ø)
...java/org/stellar/sdk/TransactionPreconditions.java 94.02% <100.00%> (ø)
.../main/java/org/stellar/sdk/SorobanDataBuilder.java 87.23% <0.00%> (ø)
src/main/java/org/stellar/sdk/Transaction.java 94.00% <0.00%> (ø)
.../main/java/org/stellar/sdk/TransactionBuilder.java 87.71% <75.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant