Use llama-stack to retrieve LLM output #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manstis
reviewed
May 14, 2025
|
|
||
| logger.info("Model: %s", model_id) | ||
|
|
||
| response = client.inference.chat_completion( |
Contributor
There was a problem hiding this comment.
You should really be using a llama-stack Agent to handle this.
Agents in llama-stack can handle all of steps in a LLM call:
- Safety Shields on incoming message ("Question validity")
- Inference
- MCP (etc) Tool calling
- Safety Shields on outgoing responses ("Answer redaction")
You are currently only using llama-stack's inference provider.
Happy to help guide you more.. this is why it's important we sync up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use llama-stack to retrieve LLM output
Type of change