-
Notifications
You must be signed in to change notification settings - Fork 58
LCORE-470: Fix agent initialization in streaming_query #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…processing requests.
WalkthroughAn explicit asynchronous call to Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Endpoint
participant AsyncAgent
Client->>Endpoint: Send streaming query request
Endpoint->>AsyncAgent: Instantiate AsyncAgent
Endpoint->>AsyncAgent: await initialize()
Endpoint->>AsyncAgent: Further logic (reuse, assign conversation ID, etc.)
AsyncAgent-->>Endpoint: Ready for processing
Endpoint-->>Client: Continue response flow
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5-10 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
maorfr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
possibly related to #317 |
tisnik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| enable_session_persistence=True, | ||
| ) | ||
|
|
||
| await agent.initialize() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
Description
Fixed the bug about requiring the agent to be initialized in streaming_query.
Type of change
Related Tickets & Documents
Checklist before requesting a review
Testing
Summary by CodeRabbit