-
Notifications
You must be signed in to change notification settings - Fork 56
LCORE-472: Add data collection documentation #389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdds documentation to README.md describing user data collection configuration (YAML example) and a Data Export Integration with the lightspeed-to-dataverse-exporter, including quick integration steps and a repo link. Changes are documentation-only; no code or public API changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🧰 Additional context used🪛 markdownlint-cli2 (0.17.2)README.md221-221: Unordered list style (MD004, ul-style) 222-222: Unordered list style (MD004, ul-style) 223-223: Unordered list style (MD004, ul-style) 224-224: Unordered list style (MD004, ul-style) 🔇 Additional comments (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (4)
README.md (4)
12-13: Clarify Dataverse branding/scope to avoid implying vendor lock-inRecommend neutral phrasing since the exporter should work with any Dataverse instance.
-The service includes comprehensive user data collection capabilities for various types of user interaction data, which can be exported to Red Hat's Dataverse for analysis using the companion [lightspeed-to-dataverse-exporter](https://github.com/lightspeed-core/lightspeed-to-dataverse-exporter) service. +The service includes comprehensive user data collection capabilities for various types of user interaction data, which can be exported to Dataverse (including Red Hat's internal instance) for analysis using the companion [lightspeed-to-dataverse-exporter](https://github.com/lightspeed-core/lightspeed-to-dataverse-exporter) service.
27-27: Fix markdownlint MD007: unordered list indentation (ToC)mdlint expects 2 spaces for nested bullets; this entry uses 4. Either regenerate the ToC (preferred) or adjust indentation consistently.
- * [User data collection](#user-data-collection) + * [User data collection](#user-data-collection)Note: Other ToC nested bullets also use 4 spaces; consider regenerating the full ToC via vim-markdown-toc to make all entries consistent.
213-216: Fix markdownlint MD004: unordered list styleThe linter expects asterisks for list items; these lines use dashes.
-- `feedback_enabled`: Enable/disable collection of user feedback data -- `feedback_storage`: Directory path where feedback JSON files are stored -- `transcripts_enabled`: Enable/disable collection of conversation transcripts -- `transcripts_storage`: Directory path where transcript JSON files are stored +* `feedback_enabled`: Enable/disable collection of user feedback data +* `feedback_storage`: Directory path where feedback JSON files are stored +* `transcripts_enabled`: Enable/disable collection of conversation transcripts +* `transcripts_storage`: Directory path where transcript JSON files are stored
456-466: Ensure path consistency across docsThis snippet uses /shared/data/... while the earlier config examples under “Llama Stack as separate server/client” use /tmp/data/.... Readers may assume those are interchangeable. Consider aligning these paths or adding a short note explaining that any path works as long as both services use the same mount.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md(5 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
README.md
27-27: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
213-213: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
214-214: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
215-215: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
216-216: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: e2e_tests
7cbdfc7 to
fd94d20
Compare
umago
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems quite reasonable by pointing just hinting about the dataverse exporter while linking/guiding users to the exporter documentation for a full configuration/setup. LGTM
tisnik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Add data collection documentation
Relevant PR in exporter side lightspeed-core/lightspeed-to-dataverse-exporter#26
Type of change
Related Tickets & Documents
Checklist before requesting a review
Testing
Summary by CodeRabbit