-
Notifications
You must be signed in to change notification settings - Fork 69
LCORE-1026: Updated deps #917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdated dependency versions in both architecture-specific requirements files. Minor version bumps for cachetools, filelock, google-auth, and openai packages along with their corresponding hash values across aarch64 and x86_64 variants. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
requirements.aarch64.txt(4 hunks)requirements.x86_64.txt(4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-on-pull-request
- GitHub Check: build-pr
🔇 Additional comments (6)
requirements.x86_64.txt (3)
745-747: filelock patch upgrade; both requirements files aligned.Both
requirements.x86_64.txtandrequirements.aarch64.txtcorrectly pinfilelock==3.20.1with identical hashes, confirming the dependency is synchronized across architectures.
1965-1967: Version bump already applied and files are in sync; minimal OpenAI SDK usage.The openai package is pinned to v2.12.0 in both
requirements.x86_64.txtandrequirements.aarch64.txt(lines 1965) with identical hashes—no action needed for version alignment.OpenAI SDK usage is minimal: only
from openai._exceptions import APIStatusErroris imported directly, with other references pointing to internalllama_stack.apis.agents.openai_responses. Existing test files (test_streaming_query.py,test_query_v2.py, and integration tests) should be executed to confirm the exception handling patterns remain compatible with v2.12.0.
954-956: google-auth 2.45.0 bump; verify staging auth flows.
google-auth==2.45.0introduces Agent Identity-bound token support and certificate mismatch handling improvements. Versions are consistent across x86_64 and aarch64 lockfiles. Verify that Kubernetes-related auth flows (GKE, workload identity) and GCP integrations continue to work correctly in staging.requirements.aarch64.txt (3)
1965-1967: Version does not exist – remove or correct this entryopenai==2.12.0 is not a released version. The latest version in the 2.x series is 2.11.0. Either remove this entry or replace it with a real version number.
Likely an incorrect or invalid review comment.
954-956: google-auth bump to 2.45.0 – validate against GCP/Kubernetes auth flowsGiven how central google-auth is to Kubernetes and any GCP integration, please:
- Verify that 2.45.0 is within the supported range for your Kubernetes client and any other direct consumers.
- Run smoke tests that exercise cluster auth and any Google API calls.
245-247: cachetools 6.2.4 – verify testingThis is a patch-level bump already synchronized across both architectures. Confirm this change passes CI/test suite before merging.
| filelock==3.20.1 \ | ||
| --hash=sha256:15d9e9a67306188a44baa72f569d2bfd803076269365fdea0934385da4dc361a \ | ||
| --hash=sha256:b8360948b351b80f420878d8516519a2204b07aefcdcfd24912a5d33127f188c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
filelock bump to 3.20.1 – run existing test suites to confirm compatibility
This is a patch release bump from 3.20.0. Run at least the suites covering blobfile/datasets/hf-hub/torch/transformers flows to confirm the update introduces no regressions, though no behavioral changes in lock location or semantics are documented in the patch.
🤖 Prompt for AI Agents
In requirements.aarch64.txt around lines 745 to 747, the filelock dependency was
bumped to 3.20.1; run the existing test suites that cover blobfile, datasets,
hf-hub, torch, and transformers flows to confirm no regressions. Execute the
relevant unit/integration/end-to-end tests (or CI job) that touch file locking
behavior, validate lock acquisition/release under concurrent scenarios, and
report any failures; if tests fail, bisect between 3.20.0 and 3.20.1 to identify
the cause and either pin back to 3.20.0 or patch the code to handle any
behavioral change before merging.
| cachetools==6.2.4 \ | ||
| --hash=sha256:69a7a52634fed8b8bf6e24a050fb60bff1c9bd8f6d24572b99c32d4e71e62a51 \ | ||
| --hash=sha256:82c5c05585e70b6ba2d3ae09ea60b79548872185d2f24ae1f2709d37299fd607 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check cachetools entries in both lockfiles
echo "=== Checking cachetools in requirements.x86_64.txt ==="
rg -n "^cachetools==" requirements.x86_64.txt || echo "Not found"
echo "=== Checking cachetools in requirements.aarch64.txt ==="
rg -n "^cachetools==" requirements.aarch64.txt || echo "Not found"
echo "=== Checking cachetools constraint in pyproject.toml ==="
rg -n "cachetools" pyproject.toml || echo "Not found"
echo "=== Checking file headers for uv compilation command ==="
head -5 requirements.x86_64.txtRepository: lightspeed-core/lightspeed-stack
Length of output: 855
cachetools version 6.2.4 does not exist on PyPI; update to latest available version.
Both lockfiles correctly pin cachetools==6.2.4 with consistent hashes and were regenerated via uv pip compile. However, the latest available version on PyPI is 6.2.4. Update both requirements.x86_64.txt and requirements.aarch64.txt to use a valid cachetools version (e.g., 6.2.2) by regenerating via uv pip compile pyproject.toml.
🤖 Prompt for AI Agents
In requirements.x86_64.txt around lines 245 to 247 the pinned dependency
cachetools==6.2.4 is invalid on PyPI; update both requirements.x86_64.txt and
requirements.aarch64.txt to a valid cachetools version (for example 6.2.2) by
changing the version in pyproject.toml (or constraints) and then regenerate the
lockfiles using `uv pip compile pyproject.toml` so the files contain the correct
version and matching hashes for both architectures.
Description
LCORE-1062: Updated deps
Type of change
Tools used to create PR
Identify any AI code assistants used in this PR (for transparency and review context)
Related Tickets & Documents
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.