-
Notifications
You must be signed in to change notification settings - Fork 70
Updated dependencies #952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated dependencies #952
Conversation
WalkthroughUpdates the faiss-cpu dependency from version 1.13.1 to 1.13.2 across two architecture-specific requirements files, along with replacing the corresponding SHA256 hash lists for each artifact. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
requirements.aarch64.txtrequirements.x86_64.txt
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: matysek
Repo: lightspeed-core/lightspeed-stack PR: 292
File: pyproject.toml:59-59
Timestamp: 2025-08-18T10:57:39.266Z
Learning: In the lightspeed-stack project, transitive dependencies like faiss-cpu are intentionally pinned as top-level dependencies to maintain better control over the dependency graph and avoid version conflicts when bundling ML/LLM tooling packages.
📚 Learning: 2025-08-18T10:57:39.266Z
Learnt from: matysek
Repo: lightspeed-core/lightspeed-stack PR: 292
File: pyproject.toml:59-59
Timestamp: 2025-08-18T10:57:39.266Z
Learning: In the lightspeed-stack project, transitive dependencies like faiss-cpu are intentionally pinned as top-level dependencies to maintain better control over the dependency graph and avoid version conflicts when bundling ML/LLM tooling packages.
Applied to files:
requirements.aarch64.txtrequirements.x86_64.txt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: build-pr
- GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-on-pull-request
- GitHub Check: E2E: server mode / ci
- GitHub Check: E2E: server mode / azure
- GitHub Check: E2E: server mode / vertexai
- GitHub Check: E2E: library mode / ci
- GitHub Check: E2E: library mode / vertexai
- GitHub Check: E2E: library mode / azure
🔇 Additional comments (1)
requirements.aarch64.txt (1)
642-657: faiss-cpu bump to 1.13.2 with regenerated hashes is correctThe version and hash block follow the standard
uv pip compile --generate-hashespattern. Version 1.13.2 satisfies the>=1.11.0constraint in pyproject.toml, and the 15 SHA256 hashes are properly formatted. This change aligns with the project's dependency management practice.
| faiss-cpu==1.13.2 \ | ||
| --hash=sha256:0ee330a284042c2480f2e90450a10378fd95655d62220159b1408f59ee83ebf1 \ | ||
| --hash=sha256:1243967eeb2298791ff7f3683a4abd2100d7e6ec7542ca05c3b75d47a7f621e5 \ | ||
| --hash=sha256:19508a1badfb36e456c1c8664eeb948349f604db5c7545f277a0126b4a84b080 \ | ||
| --hash=sha256:2c4f696ae76e7c97cbc12311db83aaf1e7f4f7be06a3ffea7e5b0e8ec1fd805b \ | ||
| --hash=sha256:7c5944d7807d58fe7244b6aba06be710ee7ed99343365ed92699349efe979f51 \ | ||
| --hash=sha256:8113a2a80b59fe5653cf66f5c0f18be0a691825601a52a614c30beb1fca9bc7c \ | ||
| --hash=sha256:85511129b34f890d19c98b82a0cd5ffb27d89d1cec2ee41d2621ee9f9ef8cf3f \ | ||
| --hash=sha256:8b32eb4065bac352b52a9f5ae07223567fab0a976c7d05017c01c45a1c24264f \ | ||
| --hash=sha256:a9064eb34f8f64438dd5b95c8f03a780b1a3f0b99c46eeacb1f0b5d15fc02dc1 \ | ||
| --hash=sha256:ab88ee287c25a119213153d033f7dd64c3ccec466ace267395872f554b648cd7 \ | ||
| --hash=sha256:b82c01d30430dd7b1fa442001b9099735d1a82f6bb72033acdc9206d5ac66a64 \ | ||
| --hash=sha256:c8b645e7d56591aa35dc75415bb53a62e4a494dba010e16f4b67daeffd830bd7 \ | ||
| --hash=sha256:c8d097884521e1ecaea6467aeebbf1aa56ee4a36350b48b2ca6b39366565c317 \ | ||
| --hash=sha256:cb4b5ee184816a4b099162ac93c0d7f0033d81a88e7c1291d0a9cc41ec348984 \ | ||
| --hash=sha256:eb8bf5dd96465d043c22195afbe8276d5197b710704290d9b454144a0ad892ed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
# Search for all faiss-cpu version references
rg -n "faiss-cpu==" -SRepository: lightspeed-core/lightspeed-stack
Length of output: 290
🏁 Script executed:
# List requirements files to identify aarch64 variant
fd -t f "requirements.*\.txt$"Repository: lightspeed-core/lightspeed-stack
Length of output: 173
The faiss-cpu bump to 1.13.2 in requirements files is correct, but outdated references remain elsewhere
The upgrade to faiss-cpu==1.13.2 is correctly applied and in sync across both requirements.x86_64.txt and requirements.aarch64.txt. However, test.containerfile (line 6) still references faiss-cpu==1.11.0 and docs/getting_started.md (line 59) references faiss-cpu==1.11.0.post1. These stale references should be updated to 1.13.2 to maintain consistency across the repository.
🤖 Prompt for AI Agents
In test.containerfile (line 6) and docs/getting_started.md (line 59) replace the
stale faiss-cpu versions (==1.11.0 and ==1.11.0.post1) with the current pinned
version faiss-cpu==1.13.2 so they match requirements.x86_64.txt and
requirements.aarch64.txt; update the exact token (including any ".post1") to
"==1.13.2" and save the files.
Description
Updated dependencies
Type of change
Tools used to create PR
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.