Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

newSpan not confirming type assertion (panic) #182

Closed
iheanyi opened this issue Oct 30, 2018 · 2 comments
Closed

newSpan not confirming type assertion (panic) #182

iheanyi opened this issue Oct 30, 2018 · 2 comments

Comments

@iheanyi
Copy link

iheanyi commented Oct 30, 2018

Is this intentional? This line specifically here should probably be refCtx, ok and if it's !ok, it should bail out. Unless there's a good reason for it panicking that I'm unaware of. I was burned by this today unexpectedly, so any insights would be great. Thank you!
iredelmeier added a commit that referenced this issue Oct 30, 2018
@iredelmeier
Allow new spans to have external references
6237649 
[Fixes #182]
@iredelmeier iredelmeier mentioned this issue Oct 30, 2018
Merged
@iredelmeier
Copy link
Contributor

No reason that I am aware of. #183 should fix it.

iredelmeier added a commit that referenced this issue Nov 1, 2018
@iredelmeier
Allow new spans to have external references (#183)
c9cafc0 
Fixes #182
@iheanyi
Copy link
Author

iheanyi commented Nov 1, 2018 •
edited
Loading

Thank you for fixing this @iredelmeier! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iheanyi @iredelmeier