Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gopsutil to v3 for macOS/arm64 (Apple M1) compatibility #280

Merged
merged 2 commits into from
May 27, 2021

Conversation

alexfjw
Copy link
Contributor

@alexfjw alexfjw commented Apr 19, 2021

Hi, I've updated gopsutil to v3 so macOS/arm64 devices can build this project locally.

See shirou/gopsutil#1000 regarding gopsutil-v2 incompatibility with macOS/arm64.
There are similar updates done on other open source repos, eg. kubernetes/minikube#10115

Tested locally with go version go1.16 darwin/arm64.

@whopper
Copy link

whopper commented May 27, 2021

👍 this is definitely needed!

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contrib @alexfjw!

@codeboten codeboten merged commit de09fbe into lightstep:master May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants