Output zero values at reset points #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where the former code skips a point because the reset timestamp is not known, the sidecar will now output a zero value. This lets us avoid skipping these points, meaning a metric name will be seen earlier by the backend.
Removes a metric counting these events. Removes a number of error conditions that were already unlikely.
Note: This creates a zero-width cumulative value, which is not strongly specified in OTLP. Stackdriver does not allow this condition. Speaking for Lightstep, this seems like a fine outcome.
Metric systems that dislike 0-width 0-value points may simply drop these points. @jmacd will track this work with the OTel metrics data model SIG, see open-telemetry/opentelemetry-proto#292.
(LS-23350)