Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard/route53 #26

Merged
merged 28 commits into from
Nov 10, 2022
Merged

Dashboard/route53 #26

merged 28 commits into from
Nov 10, 2022

Conversation

hecomp
Copy link

@hecomp hecomp commented Nov 3, 2022

  • Added route53

Heber Silva and others added 22 commits July 22, 2022 17:25
wip
12db965
Merge pull request #6 from lightstep/aws-aurora-dashboard-version
3bffe0a 
revert provider version to v1.60.2
bump provider version to v1.60.3
a1f516d
Merge pull request #7 from lightstep/aws-aurora-dashboard-version
9dc4ba3 
bump provider version to v1.60.3
revert provider version to v1.60.2
e0f3e8e
Merge pull request #8 from lightstep/aws-aurora-dashboard-version
fd8e902 
revert provider version to v1.60.2
Added aws aurora dashboard metrics
39a0e66
Merge pull request #9 from lightstep/aws-aurora-dashboard-metrics
bf31257 
Added aws aurora dashboard metrics
Fixed aws aurora dashboard timeseries operator
071d052
Merge pull request #10 from lightstep/aws-aurora-dashboard-metrics
7052952 
Fixed aws aurora dashboard timeseries operator
Fixed aws aurora dashboard timeseries operator
f4055ba
Merge pull request #11 from lightstep/aws-aurora-dashboard-metrics
0565bee 
Fixed aws aurora dashboard timeseries operator
Modified aurora time series value
6cde58a
Merge pull request #12 from lightstep/aws-aurora-dashboard-metrics
01626fa 
Modified aurora time series value
Modified count and sum timeseries
196bd27
Merge pull request #13 from lightstep/aws-aurora-dashboard-metrics
ac7ed56 
Modified count and sum timeseries
Testing aws rds terraform gen (#14)
0565061
Demo lightstep aws rds (#16)
3e0322a 
* Testing aws rds terraform gen
Testing aws rds terraform gen (#17)
1640fa9
Testing aws rds terraform gen (#18)
d96d234
@hecomp
/feature adding aws Terraform main.tf, variable.tf, outputs.tf for re…
db234d5 
…dshift
Added route 53
8ca038c
@hecomp hecomp marked this pull request as ready for review November 3, 2022 15:12
@hecomp hecomp requested a review from smithclay November 3, 2022 22:15
nslaughter
nslaughter requested changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@nslaughter nslaughter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes to Aurora and RDS shouldn't be included.

Also ROUTE53 shouldn't be all caps.

nslaughter
nslaughter approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@nslaughter nslaughter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this based on some changes to patch the merge.

@nslaughter nslaughter merged commit 54a91ba into main Nov 10, 2022
githubsands pushed a commit that referenced this pull request Jan 10, 2023
@nslaughter
Dashboard/route53 (#26)
742ac8d 
Co-authored-by: Nathan Slaughter <28688390+nslaughter@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nslaughter nslaughter nslaughter approved these changes

@smithclay smithclay Awaiting requested review from smithclay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hecomp @nslaughter