Add current version provider #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nslaughter
force-pushed
the
add-modern-ls-provider
branch
from
e8c5500 to
f6fdb29
Compare
smithclay
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Expands version constraint for Lightstep providers utilized in various modules.
Why?
We need to support multiple Lightstep provider versions, because certain modules utilize types which aren't available in other versions. Specifically, current modules use the "lightstep_metric_dashboard" type which is unsupported in v1.70.9 and the type exported from the app is "lightstep_dashboard" which is unsupported in v1.60.2. It's important that we be able to add modules using the latest provider, because (a) we should stay current with provider development, (b) staying current with the provider is the only way we can validate code with the API, and (c) more recent provider versions enable representation of the average statistic in the way described by CloudWatch docs and the average statistic features prominently in other AWS dashboards.