AWS eks terraform dashboard #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hecomp
commented
Feb 10, 2023
hecomp
commented
- Added aws eks terraform dashboard
nslaughter
reviewed
Feb 10, 2023
There was a problem hiding this comment.
This is looking good @hecomp. Thanks for going ahead and getting this dashboard up. Two action items.
- First, I think we should generally Title Case the metric names and acronyms like CPU should be capitalized
- Second, since it is so large and the dashboards for these are frequently split, I think we should split to eks-node-dashboard and eks-pod-dashboard, then remove the prefix from chart names so we don't repeat whether it is a NODE or POD metric for every case.
Here's an example application of both items:
A chart called "node cpu system" would now be in eks-node-dashboard/main.tf and the new name would be "CPU System."
nslaughter
approved these changes
Mar 2, 2023
hecomp
pushed a commit
that referenced
this pull request
Mar 4, 2023
* added aws eks terraform dashboard * resolved fmt * resolved fmt * resolved fmt * modified readme * added lisc and readme * Splitted eks-dashboard to eks-pod-* and eks-node-* * resolved * modified eks node and pod * resolved fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.