Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return ownership for all candidate moves #322

Merged
merged 3 commits into from
Oct 4, 2020

Conversation

sanderland
Copy link
Contributor

@sanderland sanderland commented Sep 27, 2020

This includes the ownership map in all 'moveInfos' objects for the analysis engine.

Probably needs some cleaning up and could be optimized, but opening this PR to see if you're interested in including this.
I'm using it to experiment with 'simple moves' AIs on the front-end side.

@lightvector
Copy link
Owner

Yeah, seems plausible. Yeah, maybe would be good to do in a way that factors out some of the logic into a common function and worth thinking about optimization and avoiding duplicating work with main ownership and the amount of data sent back. But I could certainly see adding this option.

@sanderland
Copy link
Contributor Author

Cleaned it up a bit, factored out formatting function and such, and introduced a documented option for doing this.
Had a look at if the root+children ownership could easily be retrieved in one go, and found the answer to be no, probably not worth introducing bugs over premature optimization.

@sanderland sanderland mentioned this pull request Sep 30, 2020
@lightvector lightvector merged commit 4cf64ef into lightvector:master Oct 4, 2020
@lightvector
Copy link
Owner

Merged, along with a few additional cleanups in 656414c

Thanks!

@lightvector
Copy link
Owner

Including, if it matters, one slight change to the semantics - the per-move ownership option no longer implies the root ownership option. They're just independent options now.

@sanderland sanderland deleted the allowner branch October 4, 2020 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants