Waveguide rounded corners upgrades #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Ferreira de Lima <tlima@princeton.edu>
…too small for the rounded path, but an S curve would work
…uide is zero-length
thomaslima
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given some user feedback, I caught some algorithm errors in the code that rounds waveguide corners. They only occur in edge cases.
In addition, I have improved the error messaging so they appear less cryptic and show exactly what went wrong and where. For example, from "Not enough space for enough turns" to "Not enough space to complete arcs in rounded waveguide".
When there's an error in
layout_waveguide_from_points, a warning with a traceback will be issued so that the user can locate the offending code more easily.I have added a function
waveguide_from_pointswith the same signature oflayout_waveguide_from_pointsthat returns the point list and width list to be called bylayout_waveguide. This is useful to draw additional features around a rounded waveguide.