-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URL convention is inconsistent with one recommended by IPFS #5
Comments
Thanks for the hint - there is now support for fs://ipfs/ and fs://ipns/ - so that means now I just have to remove ipfs:// and ipns:// support and this can be closed? I thought fs://* is additional to ipns:// and ipfs:// |
@ligi it should always be The same applies to the other supported but not-preferred schemas: Btw I'll be happy to help out whenever you run into Android+IPFS issues -- I ported cjdns to Android in the past and I know it can be a little challenging at times :) |
Interesting - first I thought this is not possible for Intent-Filters on android as the documentation states:
http://developer.android.com/guide/topics/manifest/data-element.html But I just did some experiments and it seems to be possible to write an intent-filter to match this kind of URIs. But this has 2 drawbacks: Just asked on StackOverflow to get some more input on this: http://stackoverflow.com/questions/36994704/intent-filters-with-pathpattern-for-authority-less-uris |
I added authority-less URI support with a34a479 - but not yet feel good about the broad intent-filters for all of fs:/* - but not yet found a way around it - perhaps we should report this need upstream to android to get the ability to have narrower filters for authority-less URIs |
|
Great! then I saw problems where none is and I can close this issue as it is solved with a34a479 |
IPFS recommends using either canonical form. Examples:
/ipfs/Qm...
./ipns/Qm...
If protocol is required use authority less
fs
protocol. Examples:fs:/ipfs/Qm...
.fs:/ipns/Qm...
- notice lack of double slashSee: ipfs/kubo#1678 (comment)
The text was updated successfully, but these errors were encountered: