Task1 #1
Task1 #1
Conversation
| @@ -0,0 +1,60 @@ | |||
| from django.core.management.base import BaseCommand, CommandError | |||
| from faker import Faker | |||
| import random | |||
There was a problem hiding this comment.
По pep8 идут сначала импорты стандартных библиотек, затем установленных, а потом локальных (и все группы разделяются пробелами):
https://www.python.org/dev/peps/pep-0008/#imports
import random
from datetime import time
from django...
| POSTGRES_USER=dbuser | ||
| POSTGRES_DB=task1 | ||
| POSTGRES_PASSWORD=dbpasswd | ||
| POSTGRES_HOST=db | ||
| POSTGRES_PORT=5432 |
There was a problem hiding this comment.
It should be .env.example, .env is meant to be in the start-ready environment.
| SECRET_KEY = 'django-insecure-_101p89468^yfmb3wl7*k@wim8k0_mx$w6t@@tq1iaz11_-&e&' | ||
|
|
||
| # SECURITY WARNING: don't run with debug turned on in production! | ||
| DEBUG = True | ||
|
|
||
| ALLOWED_HOSTS = [] |
There was a problem hiding this comment.
These config params should be the environment variables, especially, SECRET_KEY
| OpenTime = models.TimeField() | ||
| CloseTime = models.TimeField() | ||
| # TODO: Add check of unique DayOfWeek for one Store | ||
| DayOfWeek = models.IntegerField(validators=[MinValueValidator(0), MaxValueValidator(7)]) |
There was a problem hiding this comment.
Class fields should be in the snake case.
| OpenTime = models.TimeField() | ||
| CloseTime = models.TimeField() | ||
| # TODO: Add check of unique DayOfWeek for one Store | ||
| DayOfWeek = models.IntegerField(validators=[MinValueValidator(0), MaxValueValidator(7)]) |
There was a problem hiding this comment.
What about enum.Enum or django's TextChoices? It probably would be a bit more clear and readable
| from django.shortcuts import render | ||
|
|
||
| # Create your views here. |
| Django>=4.0,<5.0 | ||
| psycopg2-binary | ||
| djangorestframework | ||
| django-filter | ||
| ipython | ||
| Faker |
There was a problem hiding this comment.
pip freeze requirements.txt would set specific versions of your environment automatically for your requirements file.
No description provided.