Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pinned requirements #209

Closed
Ohjeah opened this issue Feb 18, 2019 · 3 comments
Closed

Pinned requirements #209

Ohjeah opened this issue Feb 18, 2019 · 3 comments
Labels
enhancement
Milestone
1.2.0

Comments

@Ohjeah
Copy link

Ohjeah commented Feb 18, 2019

Pinning all requirements to exact versions makes notifiers conflict with other packages in bigger projects and thus unusable as a library.

Maybe consider just pinning minimum version requirements?
@welcome
Copy link

welcome bot commented Feb 18, 2019

Thanks for opening your first issue here! Be sure to follow the issue template! 👋🐞👋

@liiight
Copy link
Owner

liiight commented Feb 25, 2019

You're absolutely right, will do

@liiight liiight added this to the 1.2.0 milestone Mar 11, 2019
rshipp added a commit to InQuest/ThreatIngestor that referenced this issue Mar 22, 2019
@rshipp
Make notifiers an optional dependency
1ba2bf8 
We need liiight/notifiers#209.
@liiight liiight mentioned this issue Jun 23, 2019
Merged
@liiight liiight mentioned this issue Jul 18, 2019
Closed
@liiight
Copy link
Owner

liiight commented Jul 25, 2019

Fixed in 1.2.0

@liiight liiight closed this as completed Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
2 participants
@liiight @Ohjeah