Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smtp/#210 disable login #266

Merged
merged 5 commits into from
Jun 13, 2019
Merged

Smtp/#210 disable login #266

merged 5 commits into from
Jun 13, 2019

Conversation

liiight
Copy link
Owner

@liiight liiight commented Jun 13, 2019 •
edited
Loading

Added new login keyword to SMTP/Gmail, with a default of True

@codecov
Copy link

codecov bot commented Jun 13, 2019 •
edited
Loading

Codecov Report

Merging #266 into 1.2.0 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##            1.2.0     #266   +/-   ##
=======================================
  Coverage   95.11%   95.11%           
=======================================
  Files          52       52           
  Lines        2169     2169           
=======================================
  Hits         2063     2063           
  Misses        106      106
Impacted Files Coverage Δ
notifiers/providers/email.py 90.66% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c600c2...cb0a270. Read the comment docs.

@TravisBuddy
Copy link

Hey @liiight,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 0b3811a0-8de2-11e9-9089-57d5c73fda02

@liiight liiight merged commit eb91e9c into 1.2.0 Jun 13, 2019
@liiight liiight deleted the smtp/#210_disable_login branch June 13, 2019 13:50
@liiight liiight added this to the 1.2.0 milestone Jun 13, 2019
liiight added a commit that referenced this pull request Jun 24, 2019
@liiight
Smtp/#210 disable login (#266)
481640e 
* made login to smtp server optional. Closes #210

* updated docs

* updated docs

* added pr issue to changelog

* updated changelog
liiight added a commit that referenced this pull request Jun 24, 2019
@liiight
Smtp/#210 disable login (#266)
25a1695 
* made login to smtp server optional. Closes #210

* updated docs

* updated docs

* added pr issue to changelog

* updated changelog
liiight added a commit that referenced this pull request Jul 25, 2019
@liiight
Smtp/#210 disable login (#266)
bdbad6f 
* made login to smtp server optional. Closes #210

* updated docs

* updated docs

* added pr issue to changelog

* updated changelog
liiight added a commit that referenced this pull request Jul 25, 2019
@liiight
Smtp/#210 disable login (#266)
272c521 
* made login to smtp server optional. Closes #210

* updated docs

* updated docs

* added pr issue to changelog

* updated changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@liiight @TravisBuddy