-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding support to victorops #401
Conversation
� Conflicts: � notifiers/providers/victorops.py
for more information, see https://pre-commit.ci
instead of at `github.com/pre-commit/pre-commit`, instead to `gitlab.com/pycqa/flake8`
F541 f-string is missing placeholders
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! I hope to get the base branch test stable in the next few days, I'll let you know when to pull so that tests can pass.
Also, please add tests if possible
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
# Conflicts: # tests/providers/test_victorops.py
for more information, see https://pre-commit.ci
This would be very useful! Looking forward to it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few more tweaks :-)
and using lower case for message_type field
for more information, see https://pre-commit.ci
and using lower case for message_type field
and using lower case for message_type field
raising errors for unsupported value of annotations
for more information, see https://pre-commit.ci
raising errors for unsupported value of annotations
# Conflicts: # notifiers/providers/victorops.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor comment about that description, but looks good to go to me!
for more information, see https://pre-commit.ci
I'll rebase and merge this after #404 is done, i'm doing a bunch of maintenance there |
No description provided.