adding support to victorops #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
� Conflicts: � notifiers/providers/victorops.py
for more information, see https://pre-commit.ci
instead of at `github.com/pre-commit/pre-commit`, instead to `gitlab.com/pycqa/flake8`
F541 f-string is missing placeholders
liiight
requested changes
Jul 19, 2021
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
# Conflicts: # tests/providers/test_victorops.py
for more information, see https://pre-commit.ci
|
This would be very useful! Looking forward to it |
and using lower case for message_type field
for more information, see https://pre-commit.ci
and using lower case for message_type field
and using lower case for message_type field
liiight
reviewed
Aug 7, 2021
raising errors for unsupported value of annotations
for more information, see https://pre-commit.ci
liiight
reviewed
Aug 9, 2021
raising errors for unsupported value of annotations
# Conflicts: # notifiers/providers/victorops.py
liiight
approved these changes
Aug 9, 2021
for more information, see https://pre-commit.ci
|
I'll rebase and merge this after #404 is done, i'm doing a bunch of maintenance there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.