-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/cherry pick 4.3 #519
Conversation
…static for makeClient().
Co-Authored-By: Alexis Lefebvre <alexislefebvre@users.noreply.github.com>
7487143
to
477fbe0
Compare
477fbe0
to
072fa22
Compare
Thanks @Simperfit! |
|
||
// Compatibility layer for Symfony 4.3+ | ||
if (class_exists('Symfony\Bundle\FrameworkBundle\KernelBrowser')) { | ||
class_alias('Symfony\Bundle\FrameworkBundle\KernelBrowser', 'Symfony\Bundle\FrameworkBundle\Client'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hum, well, noooooo
Don't miss reverting depending on how we manage to fix symfony/symfony#31762
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will add it to my todolist to revert in both 2.x and 3.x when the fix comes out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nicolas-grekas, I created an issue to keep track of this: #520
Symfony reverted the deletion of Symfony\Bundle\FrameworkBundle\Client in 4.3.1 symfony/framework-bundle@6d125a8 Obviously, the result is: |
Yes, please try the possible solution:
See #521 (comment) |
Fix #518