Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cherry pick 4.3 #519

Merged
merged 6 commits into from
Jun 5, 2019

Conversation

Simperfit
Copy link
Contributor

@Simperfit Simperfit commented Jun 5, 2019

Fix #518

.travis.yml Outdated Show resolved Hide resolved
Co-Authored-By: Alexis Lefebvre <alexislefebvre@users.noreply.github.com>
@Simperfit Simperfit force-pushed the feature/cherry-pick-4.3 branch from 7487143 to 477fbe0 Compare June 5, 2019 09:52
@Simperfit Simperfit force-pushed the feature/cherry-pick-4.3 branch from 477fbe0 to 072fa22 Compare June 5, 2019 09:53
@alexislefebvre alexislefebvre merged commit 464c7a2 into liip:2.x Jun 5, 2019
@alexislefebvre
Copy link
Collaborator

Thanks @Simperfit!

@Simperfit Simperfit deleted the feature/cherry-pick-4.3 branch June 5, 2019 11:34

// Compatibility layer for Symfony 4.3+
if (class_exists('Symfony\Bundle\FrameworkBundle\KernelBrowser')) {
class_alias('Symfony\Bundle\FrameworkBundle\KernelBrowser', 'Symfony\Bundle\FrameworkBundle\Client');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hum, well, noooooo
Don't miss reverting depending on how we manage to fix symfony/symfony#31762

Copy link
Contributor Author

@Simperfit Simperfit Jun 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add it to my todolist to revert in both 2.x and 3.x when the fix comes out

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nicolas-grekas, I created an issue to keep track of this: #520

@allartk
Copy link

allartk commented Jun 6, 2019

Symfony reverted the deletion of Symfony\Bundle\FrameworkBundle\Client in 4.3.1

symfony/framework-bundle@6d125a8

Obviously, the result is:
PHP Fatal error: Uncaught Cannot declare class Symfony\Bundle\FrameworkBundle\Client, because the name is already in use

@alexislefebvre
Copy link
Collaborator

Yes, please try the possible solution:

This should work if you downgrade to 2.0.0-alpha15 or use Symfony 4.3.0.

See #521 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants