Add support for phpunit 10

[mzk]

No description provided.

[alexislefebvre]

Thanks for the PR, please note that PHPUnit 10 isn't fully supported by Symfony yet: symfony/symfony#49069

[alexislefebvre]

Do you need help to fix the error? The liip_functional_test.validator service and PHPUnit\Framework\MockObject\MockBuilder::setMethods() are missing when PHPUnit 10 is used. We may need a compatibility layer with something like if (method_exists(…, 'setMethods')) {…} else {…} for the mocks.

[alexislefebvre]

It looks like the error in the tests comes from there:

LiipFunctionalTestBundle/src/DependencyInjection/Compiler/OptionalValidatorPass.php

Lines 23 to 25 in 07f5dcb

	if (!$container->hasDefinition('validator')) {
	$container->removeDefinition('liip_functional_test.validator');
	}

With Symfony ^5.4 or ^6.0 and PHP 8.1+, a different set of dependencies is installed. For some reason the validator is not available in this context, which removes the validator.

I wonder why tests break in this PR but not on the main branch (e.g. it works in #611).

[alexislefebvre]

Coud you please push only the commit 0b57717 on a separate PR? Once it will be merged, you'll be able to run the Actions without requiring the permission from the maintainers.

[mzk]

@alexislefebvre done in MR #619 .

[alexislefebvre]

Thanks! Please rebase this PR, the issue with PHP-CS-Fixer is fixed on the main branch.

[mzk]

rebased @alexislefebvre

[alexislefebvre]

We had to change a warning to a failing test and update the PHPUnit config. Thanks!

Please try the last release: https://github.com/liip/LiipFunctionalTestBundle/releases/tag/4.9.0