Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow doctrine/annotations 2 #613

Merged
merged 3 commits into from
Apr 4, 2023
Merged

allow doctrine/annotations 2 #613

merged 3 commits into from
Apr 4, 2023

Conversation

alexislefebvre
Copy link
Collaborator

Fixes #612

@alexislefebvre alexislefebvre mentioned this pull request Mar 30, 2023
Closed
@alexislefebvre
Copy link
Collaborator Author

Should this dependency be not mandatory?

@Nirator78
Copy link

Nirator78 commented Mar 31, 2023 •
edited
Loading

In the liip library you are using it only in the class QueryCounter

@alexislefebvre
Copy link
Collaborator Author

alexislefebvre commented Mar 31, 2023 •
edited
Loading

Yes, the bundle may not require doctrine/annotations because some users won't use QueryCounter.

@Nirator78
Copy link

Nirator78 commented Mar 31, 2023 •
edited
Loading

So what we can do ? Delete the doctrine/annotations on the LiipFunctionalTestBundle or resolve the test to allow upgrade on the library ?

@alexislefebvre alexislefebvre mentioned this pull request Apr 4, 2023
Merged
@alexislefebvre alexislefebvre force-pushed the allow-doctrine/annotations-2 branch 3 times, most recently from 63bd849 to 699e543 Compare April 4, 2023 18:49
@alexislefebvre alexislefebvre force-pushed the allow-doctrine/annotations-2 branch from 699e543 to e940543 Compare April 4, 2023 18:51
alexislefebvre
alexislefebvre commented Apr 4, 2023
View reviewed changes
.github/workflows/tests.yml
run: composer require --no-update "doctrine/annotations:^1.8.0"

- name: Require Annotations v1/v2 to require for PHP 8+
if: startsWith(matrix.php-version, '7.') != true
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reference: https://github.com/orgs/community/discussions/25017#discussioncomment-3246240

@alexislefebvre alexislefebvre merged commit add60cc into liip:master Apr 4, 2023
@alexislefebvre alexislefebvre deleted the allow-doctrine/annotations-2 branch April 4, 2023 18:58
@alexislefebvre
Copy link
Collaborator Author

I had to force doctrine/annotations v1 on PHP 7.* otherwise the CI failed, we'll check this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dependencies upgrade: doctrine/annotations
2 participants
@alexislefebvre @Nirator78