Add FileBinary[Interface] to support large files without loading them…

… unnecessarily

Binary/FileBinaryInterface.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace Liip\ImagineBundle\Binary;
+
+interface FileBinaryInterface extends BinaryInterface
+{
+    /**
+     * @return string
+     */
+    public function getPath();
+}

Binary/Loader/FileSystemLoader.php

@@ -2,7 +2,7 @@
 
 namespace Liip\ImagineBundle\Binary\Loader;
 
-use Liip\ImagineBundle\Model\Binary;
+use Liip\ImagineBundle\Model\FileBinary;
 use Symfony\Component\HttpFoundation\File\MimeType\ExtensionGuesserInterface;
 use Symfony\Component\HttpFoundation\File\MimeType\MimeTypeGuesserInterface;
 use Liip\ImagineBundle\Exception\Binary\Loader\NotLoadableException;
@@ -57,8 +57,8 @@ public function find($path)
 
         $mimeType = $this->mimeTypeGuesser->guess($absolutePath);
 
-        return new Binary(
-            file_get_contents($absolutePath),
+        return new FileBinary(
+            $absolutePath,
             $mimeType,
             $this->extensionGuesser->guess($mimeType)
         );

Imagine/Filter/FilterManager.php

@@ -4,6 +4,7 @@
 
 use Imagine\Image\ImagineInterface;
 use Liip\ImagineBundle\Binary\BinaryInterface;
+use Liip\ImagineBundle\Binary\FileBinaryInterface;
 use Liip\ImagineBundle\Binary\MimeTypeGuesserInterface;
 use Liip\ImagineBundle\Imagine\Filter\PostProcessor\PostProcessorInterface;
 use Liip\ImagineBundle\Imagine\Filter\Loader\LoaderInterface;
@@ -100,7 +101,11 @@ public function apply(BinaryInterface $binary, array $config)
             $config
         );
 
-        $image = $this->imagine->load($binary->getContent());
+        if ($binary instanceof FileBinaryInterface) {
+            $image = $this->imagine->open($binary->getPath());
+        } else {
+            $image = $this->imagine->load($binary->getContent());
+        }
 
         foreach ($config['filters'] as $eachFilter => $eachOptions) {
             if (!isset($this->loaders[$eachFilter])) {

Imagine/Filter/PostProcessor/JpegOptimPostProcessor.php

@@ -3,7 +3,8 @@
 namespace Liip\ImagineBundle\Imagine\Filter\PostProcessor;
 
 use Liip\ImagineBundle\Binary\BinaryInterface;
-use Liip\ImagineBundle\Model\Binary;
+use Liip\ImagineBundle\Binary\FileBinaryInterface;
+use Liip\ImagineBundle\Model\FileBinary;
 use Symfony\Component\Process\Exception\ProcessFailedException;
 use Symfony\Component\Process\ProcessBuilder;
 
@@ -112,7 +113,11 @@ public function process(BinaryInterface $binary)
         }
 
         $pb->add($input = tempnam(sys_get_temp_dir(), 'imagine_jpegoptim'));
-        file_put_contents($input, $binary->getContent());
+        if ($binary instanceof FileBinaryInterface) {
+            copy($binary->getPath(), $input);
+        } else {
+            file_put_contents($input, $binary->getContent());
+        }
 
         $proc = $pb->getProcess();
         $proc->run();
@@ -122,7 +127,7 @@ public function process(BinaryInterface $binary)
             throw new ProcessFailedException($proc);
         }
 
-        $result = new Binary(file_get_contents($input), $binary->getMimeType(), $binary->getFormat());
+        $result = new FileBinary($input, $binary->getMimeType(), $binary->getFormat());
 
         unlink($input);
 

Imagine/Filter/PostProcessor/OptiPngPostProcessor.php

@@ -3,7 +3,8 @@
 namespace Liip\ImagineBundle\Imagine\Filter\PostProcessor;
 
 use Liip\ImagineBundle\Binary\BinaryInterface;
-use Liip\ImagineBundle\Model\Binary;
+use Liip\ImagineBundle\Binary\FileBinaryInterface;
+use Liip\ImagineBundle\Model\FileBinary;
 use Symfony\Component\Process\Exception\ProcessFailedException;
 use Symfony\Component\Process\ProcessBuilder;
 
@@ -42,7 +43,11 @@ public function process(BinaryInterface $binary)
 
         $pb->add('--o7');
         $pb->add($input = tempnam(sys_get_temp_dir(), 'imagine_optipng'));
-        file_put_contents($input, $binary->getContent());
+        if ($binary instanceof FileBinaryInterface) {
+            copy($binary->getPath(), $input);
+        } else {
+            file_put_contents($input, $binary->getContent());
+        }
 
         $proc = $pb->getProcess();
         $proc->run();
@@ -52,7 +57,7 @@ public function process(BinaryInterface $binary)
             throw new ProcessFailedException($proc);
         }
 
-        $result = new Binary(file_get_contents($input), $binary->getMimeType(), $binary->getFormat());
+        $result = new FileBinary($input, $binary->getMimeType(), $binary->getFormat());
 
         unlink($input);
 

Model/FileBinary.php

@@ -0,0 +1,67 @@
+<?php
+
+namespace Liip\ImagineBundle\Model;
+
+use Liip\ImagineBundle\Binary\FileBinaryInterface;
+
+class FileBinary implements FileBinaryInterface
+{
+    /**
+     * @var string
+     */
+    protected $path;
+
+    /**
+     * @var string
+     */
+    protected $mimeType;
+
+    /**
+     * @var string
+     */
+    protected $format;
+
+    /**
+     * @param string $content
+     * @param string $mimeType
+     * @param string $format
+     */
+    public function __construct($path, $mimeType, $format = null)
+    {
+        $this->path = $path;
+        $this->mimeType = $mimeType;
+        $this->format = $format;
+    }
+
+    /**
+     * @return string
+     */
+    public function getContent()
+    {
+        return file_get_contents($this->path);
+    }
+
+    /**
+     * @return string
+     */
+    public function getPath()
+    {
+        return $this->path;
+    }
+
+    /**
+     * @return string
+     */
+    public function getMimeType()
+    {
+        return $this->mimeType;
+    }
+
+    /**
+     * @return string
+     */
+    public function getFormat()
+    {
+        return $this->format;
+    }
+}

Tests/Binary/Loader/FileSystemLoaderTest.php

@@ -102,7 +102,7 @@ public function testLoad($rootDir, $path)
 
         $binary = $loader->find($path);
 
-        $this->assertInstanceOf('Liip\ImagineBundle\Model\Binary', $binary);
+        $this->assertInstanceOf('Liip\ImagineBundle\Model\FileBinary', $binary);
         $this->assertStringStartsWith('text/', $binary->getMimeType());
     }
 }