-
Notifications
You must be signed in to change notification settings - Fork 379
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix handling invalid orientation in AutoRotateFilterLoader
AutoRotateFilterLoader tried to throw an exception that didn't exist when it had received an image with invalid EXIF orientation tag. It also used to fall back to exif_read_data when an old Imagine was used and it wasn't tested properly which caused breaking a build. The test is somewhat tricky. I've added an asset with a tiny JPEG that has an EXIF orientation tag. When an old imagine is used, test reads an image into memory, resets the orientation byte and makes ImageInterface mock respond with the modified image when raw JPEG is requested.
- Loading branch information
Showing
3 changed files
with
51 additions
and
24 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters