Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow_upscale not working since v0.12.0 #226

Closed
bastrapp opened this issue Aug 20, 2013 · 6 comments
Closed

allow_upscale not working since v0.12.0 #226

bastrapp opened this issue Aug 20, 2013 · 6 comments

Comments

@bastrapp
Copy link

Since the update to v0.12.0 (and imagine 0.5) the allow_upscale option is not working anymore. Pictures smaller than the filter size are not blown up to fit the dimensions. With v0.11.1 it is still working.

@ryall
Copy link

ryall commented Aug 20, 2013

@havvg
Copy link
Contributor

havvg commented Aug 21, 2013

Well, this seems to be an issue with Imagine release versioning?

@ryall
Copy link

ryall commented Aug 21, 2013

I think the library logic has just changed to not allow upscaling in the Imagine library (quite rightly I think as using 'thumbnail' for upscaling seems kind of strange).

Maybe a new filter upscale: { min-width: 100, min-height: 100 } is needed so it can be applied before the thumbnail filter.

@havvg
Copy link
Contributor

havvg commented Aug 21, 2013

There already is: RelativeResize should do the trick?

@ryall
Copy link

ryall commented Aug 21, 2013

RelativeResize assumes knowledge of which dimension is bigger (width or height) if I'm not mistaken. For example, a 50x100 image with heighten: 100 would still not force the image to fit 100x100.

@smilesrg
Copy link

Is it possible to add parameters for upscale like max[x,y], exact[x, y] and crop? Because currently it is not possible to upscale rectangle image to square using upscale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants