Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upscale filter for minimal dimensions #230

Closed
bastrapp opened this issue Sep 2, 2013 · 9 comments
Closed

upscale filter for minimal dimensions #230

bastrapp opened this issue Sep 2, 2013 · 9 comments
Labels
Level: New Feature 🆕 This item involves the introduction of new functionality.

Comments

@bastrapp
Copy link

bastrapp commented Sep 2, 2013

As brought up in #226 an "upscale" filter to ensure minimal dimensions would be handy (now, that allow_upscale is not doing the job anymore)... something like: upscale: { min-width: 100, min-height: 100 }

@ryall
Copy link

ryall commented Sep 8, 2013

+1

2 similar comments
@trsteel88
Copy link
Contributor

+1

@brizzz
Copy link

brizzz commented Sep 23, 2013

+1

@lsmith77
Copy link
Contributor

anyone got time to work on PR?

@maximecolin
Copy link
Contributor

I also need this feature so I did a pull request about it : #248

@havvg
Copy link
Contributor

havvg commented Sep 26, 2013

@bastrapp
Copy link
Author

if it works like the spreadsheet suggests it is exactly what I need.

@havvg havvg closed this as completed Sep 30, 2013
@laurentChin
Copy link

the upscale filter upscale images smaller than the minimal dimensions but upscale the taller ones too, which is not necessarily desired, any idea how to avoid this ?

@maximecolin
Copy link
Contributor

The upscale filter resize the image only if the width is smaller than the minimum width OR if the height is smaller than the minimum height.

if ($origWidth < $width || $origHeight < $height) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Level: New Feature 🆕 This item involves the introduction of new functionality.
Projects
None yet
Development

No branches or pull requests

8 participants