-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upscale filter for minimal dimensions #230
Comments
+1 |
2 similar comments
+1 |
+1 |
anyone got time to work on PR? |
I also need this feature so I did a pull request about it : #248 |
@ryall @trsteel88 @brizzz @bastrapp Can you confirm, the PR #248 provides the filter the way you need it? https://docs.google.com/spreadsheet/ccc?key=0Aj1Nx_UCbS3NdDJzU0V4U1pmTnduYkVsd1Uxeklsbnc&usp=sharing |
if it works like the spreadsheet suggests it is exactly what I need. |
the upscale filter upscale images smaller than the minimal dimensions but upscale the taller ones too, which is not necessarily desired, any idea how to avoid this ? |
The upscale filter resize the image only if the width is smaller than the minimum width OR if the height is smaller than the minimum height. if ($origWidth < $width || $origHeight < $height) { |
As brought up in #226 an "upscale" filter to ensure minimal dimensions would be handy (now, that allow_upscale is not doing the job anymore)... something like: upscale: { min-width: 100, min-height: 100 }
The text was updated successfully, but these errors were encountered: