CacheClearerInterface not found

[dangraetzer]

@sixty-nine made some changes recently to the cache clearer. are they dependent on Symfony 2.1? I'm on 2.0.12 and am getting the following error.

Fatal error: Interface 'Symfony\Component\HttpKernel\CacheClearer\CacheClearerInterface' not found in /xxx/vendor/bundles/Liip/ImagineBundle/Imagine/Cache/CacheClearer.php on line 13

My deps are the following:

[Imagine]
    git=http://github.com/avalanche123/Imagine.git
    target=imagine
    version=v0.2.0

[LiipImagineBundle]
    git=http://github.com/liip/LiipImagineBundle.git
    target=bundles/Liip/ImagineBundle

Thanks

[sixty-nine]

I am sorry, didn't check that but indeed Symfony\Component\HttpKernel\CacheClearer\CacheClearerInterface comes from Symfony 2.1.

@lsmith do you have an idea how to best solve this issue?

Meanwhile @dangraetzer you'll have to use the previous commit tag. Sorry for that.

[lsmith77]

I guess we should register the service dynamically with a version check similar to:
https://github.com/FriendsOfSymfony/FOSRestBundle/blob/master/DependencyInjection/FOSRestExtension.php#L44

[dangraetzer]

@sixty-nine what should my deps file look like?

[sixty-nine]

You can fix the version by specifying the commit number in your deps like this:

[LiipImagineBundle]
git=http://github.com/liip/LiipImagineBundle.git
target=bundles/Liip/ImagineBundle
version=af69ffeb020a8b32c86dc37d8724f791dfa09ce5

af69ffe being the ID of the commit you want to use.

[cdfre]

I'm using Symfony 2.0.15 with composer.
Could you please create a tag / branch for a working 2.0 version?

[lsmith77]

like i said .. the best fix is to just make the registration of the cache clearer depend on the Symfony version being used .. should be easy to fix .. someone just needs to write the patch and send a PR

[sixty-nine]

I assigned this ticket to myself and will fix it as soon as I find some free time (i.e. not right now).
Meanwhile if someone wants to jump into it, please feel free ;-)

[digitalkaoz]

i would like to see branches if the master is developed against 2.1...

should be the easiest thing...ran into the same issue right now :/

[lsmith77]

why branches if all it takes is an if statement to keep it all in sync. anyway i will fix it tomorrow if Dan doesnt get to it before me. but sometimes i really wonder about OSS users.

[digitalkaoz]

you got me with "oss users" ;)

[sixty-nine]

oss users can be great ;-)

thanks @digitalkaoz