Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documenting common pitfalls #828

Closed
alexwilson opened this issue Dec 1, 2016 · 4 comments
Closed

Documenting common pitfalls #828

alexwilson opened this issue Dec 1, 2016 · 4 comments
Labels
Level: Enhancement ✨ This item involves an enhancement to existing functionality. Type: Documentation This item pertains to documentation of this project. Type: Support This item pertains to support for this project.

Comments

@alexwilson
Copy link
Collaborator

Continuing on from #827...

Right now, while not strictly an issue regarding this repository, there's at the very least a common pitfall wherein without a correctly configured Symfony application + reverse proxy, we'll generate links with the wrong scheme (as we utilise Symfony's Request class).

I'm not sure if there are any other obvious ones, but I am thinking to remedy this we should start looking at building a FAQ?

@alexwilson alexwilson added Type: Documentation This item pertains to documentation of this project. Level: Enhancement ✨ This item involves an enhancement to existing functionality. Type: Support This item pertains to support for this project. labels Dec 1, 2016
@greg0ire
Copy link
Contributor

greg0ire commented Dec 1, 2016

Either a FAQ or maybe augment the web path resolver docs? That's the class where I found this piece of logic. Things to document : how it uses the request context, put a link to the symfony docs about the trusted proxies, but also maybe to the page about the request context itself in case this class is somehow used from the CLI context at some point (no idea if it is actually the case)

@cedricziel
Copy link
Collaborator

cedricziel commented Dec 2, 2016

I like the idea of adding the pitfalls to the web path resolver docs, since other resolvers (may) have their own ways of obtaining the correct path for their referenced assets. (think of flysystem for example)

@robfrawley
Copy link
Collaborator

All for improving the docs! For those not comfortable with RST, feel free to post the information you'd like added here and I'll be happy to push it into our RST documentation.

greg0ire added a commit to greg0ire/LiipImagineBundle that referenced this issue Dec 3, 2016
There are common pitfalls that can be easily avoided with some
configuration.
Closes liip#828
@greg0ire
Copy link
Contributor

greg0ire commented Dec 3, 2016

I went ahead and made #829 . Please review.

greg0ire added a commit to greg0ire/LiipImagineBundle that referenced this issue Dec 3, 2016
There are common pitfalls that can be easily avoided with some
configuration.
Closes liip#828
greg0ire added a commit to greg0ire/LiipImagineBundle that referenced this issue Dec 3, 2016
There are common pitfalls that can be easily avoided with some
configuration.
Closes liip#828
greg0ire added a commit to greg0ire/LiipImagineBundle that referenced this issue Dec 3, 2016
There are common pitfalls that can be easily avoided with some
configuration.
Closes liip#828
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Level: Enhancement ✨ This item involves an enhancement to existing functionality. Type: Documentation This item pertains to documentation of this project. Type: Support This item pertains to support for this project.
Projects
None yet
Development

No branches or pull requests

4 participants