Added option to disable cache_clearer #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -159,13 +159,5 @@ | |||
| <argument type="service" id="filesystem" /> | |||
| </service> | |||
|
|
|||
| <!-- Cache Clearer --> | |||
There was a problem hiding this comment.
please also remove the liip_imagine.cache.clearer.class parameter from this file
lsmith77
added a commit
that referenced
this pull request
Aug 23, 2012
Added option to disable cache_clearer
|
thought about this some more .. maybe |
|
not sure about this, in my opinion |
|
but it makes it sound like there is some complex logic that triggers a clear "automatically" |
|
you're right, guess we should change it then. shall i create another PR for this? |
|
that would be very much appreciated! |
|
btw. i think you meant |
|
yes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new option
auto_clear_cacheso the cache_clearer can be disabled.This PR fixes #89