Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Add php-cs-fixer check to Travis builds #1049

Closed
wants to merge 10 commits into from
Closed

[CI] Add php-cs-fixer check to Travis builds #1049

wants to merge 10 commits into from

Conversation

sebastianblum
Copy link
Contributor

@sebastianblum sebastianblum commented Feb 5, 2018 •
edited by robfrawley
Loading

Q A
Branch? 2.0
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? no
Fixed tickets #1040
License MIT
Doc PR

This PR adds a required php-cs-fixer run to our Travis builds. It enforces the new code style rules implemented in #1040.

@sebastianblum sebastianblum mentioned this pull request Feb 5, 2018
Merged
@robfrawley robfrawley added State: Confirmed This item has been confirmed by maintainers as legitimate. Level: Enhancement ✨ This item involves an enhancement to existing functionality. Type: Configuration This item pertains to configuration of this project. Attn: Minor This issue or PR is a minor problem or minor change. labels Feb 10, 2018
@robfrawley robfrawley self-assigned this Feb 10, 2018
@robfrawley robfrawley added this to the 2.0.0 milestone Feb 10, 2018
@robfrawley robfrawley changed the title [2.0] Requires php-cs-fixer checks in travis-ci build [CI] Add php-cs-fixer check to Travis builds Feb 15, 2018
@robfrawley
Copy link
Collaborator

robfrawley commented Feb 15, 2018 •
edited
Loading

@sebastianblum I've squashed, rebased, and edited your commits; can you give my changes a once-over before I force-push them to this PR and overwrite the commits on this PR? I think everything is solid, but let me know if I missed anything.

See: 2.0...robfrawley:feature-php-cs-fixer-activation

@sebastianblum
Copy link
Contributor Author

@robfrawley great work.
I will close this pr

@robfrawley robfrawley mentioned this pull request Feb 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@robfrawley robfrawley

Labels
Attn: Minor This issue or PR is a minor problem or minor change. Level: Enhancement ✨ This item involves an enhancement to existing functionality. State: Confirmed This item has been confirmed by maintainers as legitimate. Type: Configuration This item pertains to configuration of this project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebastianblum @robfrawley